Remove std::move() in smart_holder::extract_deleter()

pybind · Aug 25, 2024 · 9adbb61 · 9adbb61
1 parent a0be89d
commit 9adbb61
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/include/pybind11/detail/struct_smart_holder.h b/include/pybind11/detail/struct_smart_holder.h
@@ -242,7 +242,7 @@ struct smart_holder {
                     std::string("smart_holder::extract_deleter() precondition failure (") + context
                     + ").");
             }
-            return std::unique_ptr<D>(new D(std::move(custom_deleter_ptr->deleter)));
+            return std::unique_ptr<D>(new D(custom_deleter_ptr->deleter)); // D must be copyable.
         }
         return nullptr;
     }