Unittests for await logic (Delete) #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EronWright
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3012 +/- ##
==========================================
+ Coverage 35.97% 36.51% +0.53%
==========================================
Files 70 70
Lines 9156 9156
==========================================
+ Hits 3294 3343 +49
+ Misses 5530 5484 -46
+ Partials 332 329 -3 ☔ View full report in Codecov by Sentry. |
blampe
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR implements a unit test for the
Deletionfunction inawait.go, which is responsiblefor the low-level logic of deleting a Kubernetes object and awaiting finalization. The function has
built-in logic for watching the object until it is finalized, and supports a hand-off to a resource-specific awaiter.
Related issues (optional)
Closes #2800