Unittests for await logic (Delete) #2800
Assignees
Labels
Comments
Closed
blampe
added a commit
that referenced
this issue
May 17, 2024
This adds await logic for DaemonSets with RollingUpdate or OnDelete update strategies. The implementation is largely based on the existing StatefulSet logic with two high-level simplifications: 1. We use [kstatus](https://pkg.go.dev/sigs.k8s.io/cli-utils/pkg/kstatus/status) to decide when a DaemonSet is ready. 2. We use a `PodAggregator` to handle reporting pod statuses. Importantly, unlike StatefulSet this means we do not currently inspect pods to decide readiness -- we only use them for informational purposes. I _think_ this is sufficient but I could easily be missing something. I haven't been able to simulate situations where this logic doesn't fully capture readiness and we would need to inspect pod statuses. A failing e2e test was added in YAML under the awkwardly name `tests/sdk/java` path. Unit tests were added around the public `Creation`, `Update`, etc. methods in order to more fully exercise timeouts and retries. To that end I introduced a mock clock package which might be controversial. IMO Go doesn't have a great OSS mock clock but something like this can be very helpful for testing. I'm still somewhat confused by the role of `await.Read` since it doesn't actually await anything, but it's implemented similar to StatefulSet as a one-shot read + readiness check. Fixes #609 Refs #2800 Refs #2799 Refs #2798
EronWright
added a commit
that referenced
this issue
May 20, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
Closes #2800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Develop unit test cases for the
Deletefunction of theawaitpackage.The text was updated successfully, but these errors were encountered: