[internal] Fix parallel test flake #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two of the examples tests install different versions of the same CRD. This works in CSA mode because they overwrite each other, but cause a conflict in SSA mode. Since CRDs are cluster-scoped, it's nontrivial to fix since the tests run in parallel. Explicitly use CSA mode until we refactor the tests to run on separate clusters.
lblackstone
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. |
aq17
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Two of the examples tests install different versions of the same CRD. This works in CSA mode because they overwrite each other, but cause a conflict in SSA mode. Since CRDs are cluster-scoped, it's nontrivial to fix since the tests run in parallel. Explicitly use CSA mode until we refactor the tests to run on separate clusters.
Related issues (optional)
Fix #2482
Related to #2243