Skip to content

Commit

Permalink
[internal] Fix parallel test flake (#2515)
Browse files Browse the repository at this point in the history
Two of the examples tests install different versions of the same CRD. This works in CSA mode because they overwrite each other, but cause a conflict in SSA mode. Since CRDs are cluster-scoped, it's nontrivial to fix since the tests run in parallel. Explicitly use CSA mode until we refactor the tests to run on separate clusters.
  • Loading branch information
lblackstone authored Jul 21, 2023
1 parent 3dc1233 commit d88c6c1
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions tests/sdk/nodejs/examples/examples_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,15 @@ func TestAccPrometheusOperator(t *testing.T) {
With(integration.ProgramTestOptions{
Dir: filepath.Join(getCwd(t), "prometheus-operator"),
SkipRefresh: true,
// TODO: set to SSA false to fix https://github.com/pulumi/pulumi-kubernetes/issues/2482.
// https://github.com/pulumi/pulumi-kubernetes/issues/2243 tracks work to split tests across different
// clusters, which would fix this problem
OrderedConfig: []integration.ConfigValue{
{
Key: "kubernetes:enableServerSideApply",
Value: "false",
},
},
ExtraRuntimeValidation: func(
t *testing.T, stackInfo integration.RuntimeValidationStackInfo,
) {
Expand Down Expand Up @@ -499,6 +508,15 @@ func TestRancher(t *testing.T) {
SkipRefresh: true,
Verbose: true,
NoParallel: true,
// TODO: set to SSA false to fix https://github.com/pulumi/pulumi-kubernetes/issues/2482.
// https://github.com/pulumi/pulumi-kubernetes/issues/2243 tracks work to split tests across different
// clusters, which would fix this problem
OrderedConfig: []integration.ConfigValue{
{
Key: "kubernetes:enableServerSideApply",
Value: "false",
},
},
EditDirs: []integration.EditDir{
{
Dir: filepath.Join(getCwd(t), "rancher", "step2"),
Expand Down

0 comments on commit d88c6c1

Please sign in to comment.