Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure registry integration test #494

Merged
merged 9 commits into from
Feb 16, 2023
Merged

Add Azure registry integration test #494

merged 9 commits into from
Feb 16, 2023

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Feb 13, 2023 •
edited
Loading

Fixes #488

Add Container Registry integration tests for Azure.

Removes extraneous login logic.
Removes js folder
Removes duplicate top-level Python test
Enables and runs these tests.

A review will check that each test added ran successfully.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

13 similar comments
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

AaronFriel and others added 9 commits February 15, 2023 10:41
@AaronFriel @guineveresaenger
fix: Docker auth config lookup portability
184db10 
On various platforms, the Docker credentials store may return keys with URLs
with a scheme ("https://") prefixed on all entries, or hostnames only. An
exception to this is the legacy Docker index server, which appears as
"https://index.docker.io/v1/".

The push auth config is now selected by first resolving a valid ("non-legacy")
entry, which will be either a hostname aka registry name, or the
"https://index.docker.io/v1/" value. This value is then passed to
`GetAuthConfig`, using the Docker library's existing lookup fallback behavior to
handle URLs.

Two additional legacy names are handled, as discovered by reading the ORAS'
project's implementation with the same goal. See:
https://github.com/oras-project/oras-go/blob/v1.2.2/pkg/auth/docker/resolver.go#L79-L86
@guineveresaenger
Alias Docker image to avoid deletion on upgrade to v4 (#483)
7fd9fd9 
* Add alias to Image

* generate schema and SDKs
@guineveresaenger
fix up nodejs test
d2d695e
@guineveresaenger
Remove JS folder
6ab7275
@guineveresaenger
Fix up Python container registry test
f4fc6f8
@guineveresaenger
Add Go Container Registry test
07425c2
@guineveresaenger
Clean up auth code and simplify
78e34a3
@guineveresaenger
Remove az-py as duplicate container registry test
22b0111
@guineveresaenger
Add dotnet registry test
2592c4f
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@guineveresaenger guineveresaenger marked this pull request as ready for review February 15, 2023 19:51
@guineveresaenger guineveresaenger requested a review from a team February 15, 2023 19:52
iwahbe
iwahbe approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are running in CI. Nice!

@guineveresaenger guineveresaenger merged commit c66fda9 into master Feb 16, 2023
@guineveresaenger guineveresaenger deleted the guin/az-registry branch February 16, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe approved these changes

Assignees

@jazzyfresh jazzyfresh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container Registry Integration test for Azure
4 participants
@guineveresaenger @iwahbe @jazzyfresh @AaronFriel