Alias Docker image to avoid deletion on upgrade to v4 #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
iwahbe
approved these changes
Feb 8, 2023
AaronFriel
approved these changes
Feb 8, 2023
guineveresaenger
added a commit
that referenced
this pull request
Feb 15, 2023
* Add alias to Image * generate schema and SDKs
guineveresaenger
added a commit
that referenced
this pull request
Feb 16, 2023
* fix: Docker auth config lookup portability
On various platforms, the Docker credentials store may return keys with URLs
with a scheme ("https://") prefixed on all entries, or hostnames only. An
exception to this is the legacy Docker index server, which appears as
"https://index.docker.io/v1/".
The push auth config is now selected by first resolving a valid ("non-legacy")
entry, which will be either a hostname aka registry name, or the
"https://index.docker.io/v1/" value. This value is then passed to
`GetAuthConfig`, using the Docker library's existing lookup fallback behavior to
handle URLs.
Two additional legacy names are handled, as discovered by reading the ORAS'
project's implementation with the same goal. See:
https://github.com/oras-project/oras-go/blob/v1.2.2/pkg/auth/docker/resolver.go#L79-L86
* Alias Docker image to avoid deletion on upgrade to v4 (#483)
* Add alias to Image
* generate schema and SDKs
* fix up nodejs test
* Remove JS folder
* Fix up Python container registry test
* Add Go Container Registry test
* Clean up auth code and simplify
* Remove az-py as duplicate container registry test
* Add dotnet registry test
---------
Co-authored-by: Aaron Friel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the alias for the v3.x.x Docker image URN token to the new, schematized Image token.
Specifically,
docker:index/image:Imageis aliased to the previousdocker:index:Image.This should avoid delete/create of a resource during upgrade to v4.