Deprecate extraOptions and env #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `env` field was used to pass along a buildkit option. This functionality has been replaced by `builderVersion`. Additionally, an `ENV` field is common to use in Dockerfiles, and to pass to containers as runtime flags, so using this name is confusing as well. ENV vars do not get passed at build time.
This field was used to pass arbitrary values to the invocation of the Docker CLI. Using the go docker SDK, we will over time add these as fully typed features.
Does the PR have any schema changes?Found 2 breaking changes: |
AaronFriel
approved these changes
Jan 27, 2023
Does the PR have any schema changes?Found 2 breaking changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up:
env- it was used to pass CLI environment variables likeBUILDKIT=1and we now havebuilderVersioninsteadextraOptions- we cannot support a grab bag of command line options when using the docker SDK.envfrom schemaenvfield from Image implementationenvtypeextraOptionsfieldFixes #469