Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up env and extraOptions types #469

Closed
guineveresaenger opened this issue Jan 27, 2023 · 0 comments · Fixed by #468
Closed

Clean up env and extraOptions types #469

guineveresaenger opened this issue Jan 27, 2023 · 0 comments · Fixed by #468
Assignees
@guineveresaenger
Labels
4.x.x kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed
Milestone
0.84

Comments

@guineveresaenger
Copy link
Contributor

env - it was used to pass CLI environment variables like BUILDKIT=1 and we now have builderVersion instead. Note that this field is not in any way related to the Docker container ENV feature at all, so removal is just obvious.

extraOptions - we cannot support a grab bag of command line options when using the docker SDK. See also: #424
@guineveresaenger guineveresaenger mentioned this issue Jan 27, 2023
Merged
@guineveresaenger guineveresaenger added the kind/task Work that's part of an ongoing epic label Jan 27, 2023
@guineveresaenger guineveresaenger self-assigned this Jan 27, 2023
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jan 27, 2023
@AaronFriel AaronFriel added this to the 0.84 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guineveresaenger guineveresaenger

Labels
4.x.x kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.84
Development

Successfully merging a pull request may close this issue.

Deprecate extraOptions and env pulumi/pulumi-docker
3 participants
@AaronFriel @guineveresaenger @pulumi-bot