Add Cache From feature #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for specifying images to use as a pull cache from a remote registry. Additionally adds log output to support surfacing of errors when cache pull is not possible.
Does the PR have any schema changes?Found 2 breaking changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
Fixes #426
The v3.x.x implementation of cacheFrom did not properly reflect its use as a Docker command flag.
This pull request enables the
cacheFromtype on thebuildtype ofdocker.Imageresource.It accepts a list of images that can be pulled from an authenticated registry to serve as a build cache.
These images must have caching metadata information associated; otherwise Docker won't find them and build without cache.
This PR in its current state removes the OneOf implementation for
cacheFrom, requiring the developer to explicitly add any image names to theimageslist. I am happy to revert this removal if we consider it necessary.There is also a slight tweak to log handling output to avoid printing bytes 😅