Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Deprecate OneOf implementation for cacheFrom #427

Closed
guineveresaenger opened this issue Nov 28, 2022 · 1 comment · Fixed by #467
Closed

Image: Deprecate OneOf implementation for cacheFrom #427

guineveresaenger opened this issue Nov 28, 2022 · 1 comment · Fixed by #467
Assignees
Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@guineveresaenger
Copy link
Contributor

Currently, the cacheFrom input on DockerBuild can either be a boolean or aCacheFrom supporting type which contains stages, a list of strings. This is implemented on current master branch as well, but it adds a lot of extra input handling to the provider logic.

Rather than allow users to set a boolean or a CacheFrom type with stages, we should remove the boolean option.
Instead, we will allow for cacheFrom to be a list of strings and add logic to determine either reasonable default (to handle the current true case) or whether this field is not set (to handle the current false case).

@pulumi-bot
Copy link
Contributor

Cannot close issue without required labels: kind/

@guineveresaenger guineveresaenger added the kind/enhancement Improvements or new features label Jan 27, 2023
@guineveresaenger guineveresaenger self-assigned this Jan 27, 2023
@guineveresaenger guineveresaenger added this to the 0.84 milestone Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants