-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker context build hash check #446
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's one change to make to meet the spec for return values for Diff()
: https://pulumi-developer-docs.readthedocs.io/en/latest/providers/implementers-guide.html#id4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - resolved the questions I had in-person. Would love to see a dedicated test case for this tho it might be tricky.
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
…s and functions to be more descriptive. Add comments.
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
This PR introduces
contextDigest
as a computed (non-schematized) resource input.Specifically, the provider's Check() function will detect any changes in the supplied docker build context and
calculate a hash of any changes, which will be passed to the resource as a
contextDigest
.When this input changes on follwing updates to the stack, the Image resource will be re-build.
If there are no changes within the Docker build context, the resource will remain unchanged.
For any users of this provider, this encourages the use of a
.dockerignore
file to avoid unnecessary rebuilds.Fixes #443.
First pass at adding contextDigest and passing in a more verbose diff
Set contextDigest in Diff as a nonschematized computed resource input