Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker build context to Diff check #443

Closed
guineveresaenger opened this issue Dec 9, 2022 · 0 comments · Fixed by #446
Closed

Add Docker build context to Diff check #443

guineveresaenger opened this issue Dec 9, 2022 · 0 comments · Fixed by #446
Assignees
Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@guineveresaenger
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

When the Docker build context (AKA the project folder referenced by the Dockerfile) has changed, an image should be re-built.

We can put this logic in the Diff checker.

Here's an example implementation for detecting changes in the Docker context: https://github.com/MaterializeInc/pulumi-docker-buildkit/blob/bed3b04f79016001c0b948d0faa1051857acd6fc/cmd/pulumi-resource-docker-buildkit/main.go#L127

  • it heavily relies on keeping your node modules in the Dockerignore file, so this might be helpful to point out to users

Affected area/feature

@guineveresaenger guineveresaenger added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team 4.x.x and removed needs-triage Needs attention from the triage team labels Dec 9, 2022
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jan 4, 2023
@guineveresaenger guineveresaenger added this to the 0.83 milestone Jan 4, 2023
@guineveresaenger guineveresaenger self-assigned this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants