Ensure skipPush defaults to false #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
guineveresaenger
changed the title
Does the PR have any schema changes?Looking good! No breaking changes found. |
guineveresaenger
added
the
impact/no-changelog-required
t0yv0
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Let's merge this. Actually would you like to go through the remaining code together and foolproof every opportunity for panics? There might be a few more.. The fully safe marshalling code is very annoying to write in Go; as an alternative we could perhaps consider coming back to #435 and reviving/cleaning it up. The automaker code does full nil checking and reports errors in terms of field coordinates automatically with less work on the caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this provider with yaml, the default
skipPush: falsewas not picked up and the provider panic()ed.This PR explicitly ensures the value of
skipPushis always false, unless set to true in the Pulumi program.Adds tests.
A minor unrelated change gives a more meaningful name to the registry marshalling function.
Fixes #437