Ensure skipPush defaults to false (#439)

* Explicitly set skipPush default to

* rename setRegistry to marshalRegistry

* better code through linting

provider/image.go

@@ -53,11 +53,12 @@ func (p *dockerNativeProvider) dockerBuild(ctx context.Context,
 		return "", nil, err
 	}
 
-	reg := setRegistry(inputs["registry"])
+	reg := marshalRegistry(inputs["registry"])
+	skipPush := marshalSkipPush(inputs["skipPush"])
 	// read in values to Image
 	img := Image{
 		Name:     inputs["imageName"].StringValue(),
-		SkipPush: inputs["skipPush"].BoolValue(),
+		SkipPush: skipPush,
 		Registry: reg,
 	}
 
@@ -296,7 +297,7 @@ func marshalCachedImages(img Image, b resource.PropertyValue) []string {
 	return cacheImages
 }
 
-func setRegistry(r resource.PropertyValue) Registry {
+func marshalRegistry(r resource.PropertyValue) Registry {
 	var reg Registry
 	if !r.IsNull() {
 		if !r.ObjectValue()["server"].IsNull() {
@@ -361,3 +362,11 @@ func marshalBuilder(builder resource.PropertyValue) (types.BuilderVersion, error
 		return version, errors.Errorf("Invalid Docker Builder version")
 	}
 }
+
+func marshalSkipPush(sp resource.PropertyValue) bool {
+	if sp.IsNull() {
+		// defaults to false
+		return false
+	}
+	return sp.BoolValue()
+}

provider/image_test.go

@@ -21,7 +21,7 @@ func TestSetRegistry(t *testing.T) {
 			"password": resource.NewStringProperty("supersecret"),
 		})
 
-		actual := setRegistry(input)
+		actual := marshalRegistry(input)
 		assert.Equal(t, expected, actual)
 	})
 	t.Run("Incomplete Registry sets all available fields", func(t *testing.T) {
@@ -34,14 +34,14 @@ func TestSetRegistry(t *testing.T) {
 			"username": resource.NewStringProperty("pulumipus"),
 		})
 
-		actual := setRegistry(input)
+		actual := marshalRegistry(input)
 		assert.Equal(t, expected, actual)
 	})
 
 	t.Run("Registry can be nil", func(t *testing.T) {
 		expected := Registry{}
 		input := resource.PropertyValue{}
-		actual := setRegistry(input)
+		actual := marshalRegistry(input)
 		assert.Equal(t, expected, actual)
 	})
 }
@@ -378,3 +378,27 @@ func TestMarshalBuilder(t *testing.T) {
 		assert.NoError(t, err)
 	})
 }
+
+func TestMarshalSkipPush(t *testing.T) {
+	t.Run("Test SkipPush defaults to false", func(t *testing.T) {
+		expected := false
+		input := resource.NewPropertyValue(nil)
+		actual := marshalSkipPush(input)
+		assert.Equal(t, expected, actual)
+
+	})
+	t.Run("Test SkipPush returns true if set to true", func(t *testing.T) {
+		expected := true
+		input := resource.NewBoolProperty(true)
+
+		actual := marshalSkipPush(input)
+		assert.Equal(t, expected, actual)
+	})
+	t.Run("Test SkipPush returns false if set to false", func(t *testing.T) {
+		expected := false
+		input := resource.NewBoolProperty(false)
+
+		actual := marshalSkipPush(input)
+		assert.Equal(t, expected, actual)
+	})
+}