Add an ASP.NET app that runs in AWS ECS Fargate #532
Conversation
This adds an example of a basic ASP.NET app that runs in AWS ECS Fargate. This includes the infrastructure required to build and publish that application as a Docker container image to a private ECR repo, spin up a new ECS Fargate cluster, run a load balancer listening for external Internet traffic on port 80, and run services across all subnets in the default VPC for the target deployment region.
aws-cs-fargate/App/Program.cs
Outdated
| using Microsoft.Extensions.Hosting; | ||
| using Microsoft.Extensions.Logging; | ||
|
|
||
| namespace dotnet_core_tutorial |
There was a problem hiding this comment.
Rename the namespace to something .NET-y
There was a problem hiding this comment.
Will do, all of this is whatever dotnet new spit out, fwiw.
| "Microsoft": "Information" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit, but I would omit this file
There was a problem hiding this comment.
Ok! Was autogenerated by dotnet new, wasn't sure what it is 😄
| @@ -0,0 +1,2 @@ | |||
| /bin/ | |||
| /obj/ | |||
There was a problem hiding this comment.
Maybe merge .gitignores in the root folder of the example?
aws-cs-fargate/Infra/Program.cs
Outdated
| // Create a SecurityGroup that permits HTTP ingress and unrestricted egress. | ||
| var webSg = new Ec2.SecurityGroup("web-sg", new Ec2.SecurityGroupArgs { | ||
| VpcId = vpc.Id, | ||
| Egress = new[] { |
There was a problem hiding this comment.
new[] is not required here and down below
aws-cs-fargate/Infra/Program.cs
Outdated
| { | ||
| static Task<int> Main() | ||
| { | ||
| return Deployment.RunAsync(async () => { |
There was a problem hiding this comment.
It's common to put { on a new line, also in our .NET code
There was a problem hiding this comment.
Alright, will fix those that are obvious.
Not quite sure what the style is meant to be in all places, e.g.
LoadBalancers = {
x
},
or
LoadBalancers =
{
x
},
Do we have plans to add style/linter checking?
There was a problem hiding this comment.
Oh my, the code is now twice as long! 🤦♂ But I shall resist the temptation to comment on style guidelines ... (oh wait, too late)
| ImageName = appRepo.RepositoryUrl, | ||
| Registry = new Docker.ImageRegistry { | ||
| Server = appRepo.RepositoryUrl, | ||
| Username = appRepoCreds.Apply(creds => creds[0]), |
There was a problem hiding this comment.
I think you should be able to do appRepoCreds.Get(0)
There was a problem hiding this comment.
Hmm: error CS1061: 'Output<string[]>' does not contain a definition for 'Get' and no accessible extension method 'Get' accepting a first argument of type 'Output<string[]>' could be found (are you missing a using directive or an assembly reference?)
There was a problem hiding this comment.
My bad, should be GetAt https://github.com/pulumi/pulumi/blob/master/sdk/dotnet/Pulumi/Core/OutputExtensions.cs#L22
aws-cs-fargate/Infra/Program.cs
Outdated
| NetworkMode = "awsvpc", | ||
| RequiresCompatibilities = new[] { "FARGATE" }, | ||
| ExecutionRoleArn = taskExecRole.Arn, | ||
| ContainerDefinitions = image.ImageName.Apply(imgName => @"[{ |
There was a problem hiding this comment.
imgName -> imageName in .NET
aws-cs-fargate/Infra/Program.cs
Outdated
|
|
||
| // Export the resulting web address. | ||
| return new Dictionary<string, object?>{ | ||
| { "url", webLb.DnsName.Apply(url => $"http://{url}") }, |
There was a problem hiding this comment.
Try changing to Output.Format
aws-cs-fargate/README.md
Outdated
| * [Install Pulumi](https://www.pulumi.com/docs/get-started/install/) | ||
| * [Install .NET Core 3](https://dotnet.microsoft.com/download) | ||
| * [Connect Pulumi to AWS](https://www.pulumi.com/docs/intro/cloud-providers/aws/setup/) (if your AWS CLI is | ||
| configured, this will just work) |
| 2 changes. 9 unchanged | ||
| ``` | ||
|
|
||
| Notice that `pulumi up` redeploys just the parts of the application/infrastructure that you've edited. |
There was a problem hiding this comment.
So does the re-publishing of the docker image work?
There was a problem hiding this comment.
It does! I filed an issue for the lack of diffs (pulumi/pulumi-docker#131) which led me astray. The root problem was that I was using the ECR registry URL and not the built image's full name, which is just the ECR registry plus the hash. The hash is required to ensure the ECS service gets restarted upon a new image being pushed.
* Add an ASP.NET app that runs in AWS ECS Fargate This adds an example of a basic ASP.NET app that runs in AWS ECS Fargate. This includes the infrastructure required to build and publish that application as a Docker container image to a private ECR repo, spin up a new ECS Fargate cluster, run a load balancer listening for external Internet traffic on port 80, and run services across all subnets in the default VPC for the target deployment region. * Incorporate code review feedback * More brace movement
This adds an example of a basic ASP.NET app that runs in AWS ECS
Fargate. This includes the infrastructure required to build and publish
that application as a Docker container image to a private ECR repo,
spin up a new ECS Fargate cluster, run a load balancer listening for
external Internet traffic on port 80, and run services across all
subnets in the default VPC for the target deployment region.