Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffs in Docker builds don't show up as diffs #131

Closed
joeduffy opened this issue Jan 29, 2020 · 4 comments
Closed

Diffs in Docker builds don't show up as diffs #131

joeduffy opened this issue Jan 29, 2020 · 4 comments
Assignees
Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@joeduffy
Copy link
Member

Due to the way we perform Docker builds, the Image resource never shows any diffs. This is confusing because, even if there are "no changes" shown, performing a pulumi up actually runs the command to perform the side effects of building and pushing the image.

Instead, I believe we should do the build and either use the resulting digest hash as an input property for the resource -- such that if the hash changes, it appears as a diff to the resource -- or, if that's not appealing, we should treat changes to output properties as a diff in the output.

@lukehoban
Copy link
Contributor

I believe this is (another) reason why we need to do #132 (just opened to track more explicitly).

@dbeattie71
Copy link

I was just looking at how this works and I'm not sure docker inspect will work for coming up with a hash of an image on two different machines without getting a different result. Does that sound right? It would be nice to override the funtionality in BuildImageAsync that gets the inspectResult so a custom implementation can be created.

@leezen
Copy link
Contributor

leezen commented Apr 30, 2021

Cross-posting for posterity, but one option is to use the RegistryImage resource (see #132 (comment) for more details on using it as a replacement for Image)

@AaronFriel AaronFriel added 4.x.x kind/enhancement Improvements or new features labels Feb 13, 2023
@AaronFriel AaronFriel added the resolution/fixed This issue was fixed label Mar 9, 2023
@AaronFriel
Copy link
Contributor

This issue is resolved with the new implementation of the Docker Image resource in v4! See our blog post for more info: https://www.pulumi.com/blog/build-images-50x-faster-docker-v4/

@mikhailshilkov mikhailshilkov added this to the 0.85 milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

7 participants