Test PRs targeting branches other than master #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only PRs targeting master* are tested.
|
Merging to expedite shipping aws v5 patches. |
blampe
added a commit
that referenced
this pull request
Jan 18, 2024
I found it surprising when trying to [stack](https://stacking.dev) some PRs that we don't run tests unless the PR is explicitly against master. This is [awkward](pulumi/pulumi-docker#948 (comment)) to work with. This PR changes our workflow to trigger for PRs against any branch. I might be missing some context around #723 and why we chose to opt-in only some patterns, but if there are automated flows that shouldn't run tests I recommend we opt those out explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In context of pulumi/pulumi-aws#3025 it would be great to be able to maintain multiple "main" branches, such as "v5" branch in AWS, and have tests qualify this branch and PRs targeting it. This change specifically enables testing PRs that target feature-* or v* branches.