Skip to content

Commit

Permalink
Run acceptance tests on all branch targets (#785)
Browse files Browse the repository at this point in the history
I found it surprising when trying to [stack](https://stacking.dev) some
PRs that we don't run tests unless the PR is explicitly against master.
This is
[awkward](pulumi/pulumi-docker#948 (comment))
to work with.

This PR changes our workflow to trigger for PRs against any branch. I
might be missing some context around #723 and why we chose to opt-in
only some patterns, but if there are automated flows that shouldn't run
tests I recommend we opt those out explicitly.
  • Loading branch information
blampe authored Jan 18, 2024
1 parent 50563f9 commit 6b71554
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,6 @@ jobs:
name: run-acceptance-tests
on:
pull_request:
branches:
- #{{ .Config.providerDefaultBranch }}#
- v*
- feature*
paths-ignore:
- CHANGELOG.md
repository_dispatch:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -439,10 +439,6 @@ jobs:
name: run-acceptance-tests
on:
pull_request:
branches:
- master
- v*
- feature*
paths-ignore:
- CHANGELOG.md
repository_dispatch:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -396,10 +396,6 @@ jobs:
name: run-acceptance-tests
on:
pull_request:
branches:
- master
- v*
- feature*
paths-ignore:
- CHANGELOG.md
repository_dispatch:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -436,10 +436,6 @@ jobs:
name: run-acceptance-tests
on:
pull_request:
branches:
- master
- v*
- feature*
paths-ignore:
- CHANGELOG.md
repository_dispatch:
Expand Down

0 comments on commit 6b71554

Please sign in to comment.