Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes odd looking css in image module #8474

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Fixes odd looking css in image module #8474

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4180f3
init
Sagarpreet Oct 7, 2020
55bc6f8
Merge branch 'main' of https://github.com/publiclab/plots2 into 1.2
Sagarpreet Oct 13, 2020
16d2eb5
addressed review comments
Sagarpreet Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/editor/rich.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@

<!-- main_image module -->
<div class="ple-module-main_image ple-module container">
<div class="ple-module-guide col-md-3"><h2>2</h2></div>
<div class="ple-module-guide" style="flex: 0 0 25%; max-width: 25%;"><h2>2</h2></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, is there something we can do about this in the CSS file rather? Or, using a native Bootstrap class? I'm just wary of inline CSS in the example files. Thank you!!!!


<div class="module-mainImage ple-module-content col-md-9 container">
<div class="mainImageBox">
Expand Down