Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes odd looking css in image module #8474

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Fixes odd looking css in image module #8474

merged 3 commits into from
Oct 13, 2020

Conversation

Sagarpreet
Copy link
Contributor

Fixes part of publiclab/PublicLab.Editor#596

BEFORE:
Screenshot 2020-10-07 at 1 49 54 PM

AFTER:
Screenshot 2020-10-07 at 1 52 50 PM

@Sagarpreet Sagarpreet requested a review from a team as a code owner October 7, 2020 08:23
@welcome
Copy link

welcome bot commented Oct 7, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Oct 7, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented Oct 7, 2020 •
edited
Loading

Codecov Report

Merging #8474 into main will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8474      +/-   ##
==========================================
- Coverage   81.91%   81.80%   -0.12%     
==========================================
  Files         101      101              
  Lines        5896     5896              
==========================================
- Hits         4830     4823       -7     
- Misses       1066     1073       +7
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.87% <0.00%> (-3.83%) ⬇️

@Sagarpreet Sagarpreet mentioned this pull request Oct 7, 2020
Closed
14 tasks
jywarren
jywarren requested changes Oct 7, 2020
View reviewed changes
app/views/editor/rich.html.erb Outdated
@@ -79,7 +79,7 @@

<!-- main_image module -->
<div class="ple-module-main_image ple-module container">
<div class="ple-module-guide col-md-3"><h2>2</h2></div>
<div class="ple-module-guide" style="flex: 0 0 25%; max-width: 25%;"><h2>2</h2></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, is there something we can do about this in the CSS file rather? Or, using a native Bootstrap class? I'm just wary of inline CSS in the example files. Thank you!!!!

@codeclimate
Copy link

codeclimate bot commented Oct 13, 2020

Code Climate has analyzed commit 16d2eb5 and detected 0 issues on this pull request.

View more on Code Climate.

@Sagarpreet Sagarpreet requested a review from jywarren October 13, 2020 06:50
@jywarren jywarren merged commit 9dfa9f4 into publiclab:main Oct 13, 2020
@jywarren
Copy link
Member

Nice!!!

piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
@Sagarpreet
Fixes odd looking css in image module (publiclab#8474)
990171a 
* init

* addressed review comments
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
@Sagarpreet @manchere
Fixes odd looking css in image module (publiclab#8474)
71ec847 
* init

* addressed review comments
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
@Sagarpreet @lagunasmel
Fixes odd looking css in image module (publiclab#8474)
9121546 
* init

* addressed review comments
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
@Sagarpreet @reginaalyssa
Fixes odd looking css in image module (publiclab#8474)
33055b0 
* init

* addressed review comments
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
@Sagarpreet
Fixes odd looking css in image module (publiclab#8474)
0d568e9 
* init

* addressed review comments
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
@Sagarpreet @billymoroney1
Fixes odd looking css in image module (publiclab#8474)
c160426 
* init

* addressed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sagarpreet @jywarren