Process blind withdrawals #11995
Merged
Process blind withdrawals #11995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Feb 16, 2023
| for i, withdrawal := range withdrawals { | ||
| if withdrawal.Index != expected[i].Index { | ||
|
|
||
| for i, withdrawal := range expectedWithdrawals { |
There was a problem hiding this comment.
This doesn't make any sense, you are comparing the same objects in each loop . Basically if a.Index != a.Index , which will never be triggered.
…prysm into process-blind-withdrawals
|
Can you add a unit test to blinded/non-blinded cases where the root doesn't match the expected root? |
terencechain
added
Ready For Review
|
Done |
rauljordan
reviewed
Feb 16, 2023
There was a problem hiding this comment.
Hi @terencechain , @saolyn and I just went through this together and the main feedback we have is that this PR should have a clear description of the changes and also why we need them. Also, a comment on ProcessWithdrawals that mentions this will work with both blinded and full execution data would be ideal. We also wanted to double check that both branches of the conditional added are covered in tests
nisdas
previously approved these changes
Feb 17, 2023
…ss-blind-withdrawals
nisdas
approved these changes
Feb 17, 2023
kasey
approved these changes
Feb 17, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a blind payload (i.e header), the withdrawal list is represented as a root. Given limited information, a node will not be able to process the state root using a withdrawal root. The node should use expected withdrawals in the state to process withdrawal when processing a blind payload.