Skip to content

Commit

Permalink
Merge branch 'fixE2EBug' of github.com:prysmaticlabs/prysm into proce…
Browse files Browse the repository at this point in the history
…ss-blind-withdrawals
  • Loading branch information
terencechain committed Feb 17, 2023
2 parents 392f1df + 9f18493 commit 299247f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
1 change: 0 additions & 1 deletion config/params/testnet_e2e_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ func E2EMainnetTestConfig() *BeaconChainConfig {
e2eConfig.MinGenesisActiveValidatorCount = 256
e2eConfig.GenesisDelay = 25 // 25 seconds so E2E has enough time to process deposits and get started.
e2eConfig.ChurnLimitQuotient = 65536
e2eConfig.MaxValidatorsPerWithdrawalsSweep = 128

// Time parameters.
e2eConfig.SecondsPerSlot = 6
Expand Down
9 changes: 8 additions & 1 deletion testing/endtoend/evaluators/operations.go
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,11 @@ func submitWithdrawal(ec *e2etypes.EvaluationContext, conns ...*grpc.ClientConn)
}

func validatorsAreWithdrawn(ec *e2etypes.EvaluationContext, conns ...*grpc.ClientConn) error {
// We skip this for multiclient runs as lighthouse does not have the ability
// to configure the withdrawal sweep for the end to end test.
if e2e.TestParams.LighthouseBeaconNodeCount > 0 {
return nil
}
conn := conns[0]
beaconClient := ethpb.NewBeaconChainClient(conn)
debugClient := ethpb.NewDebugClient(conn)
Expand Down Expand Up @@ -642,7 +647,9 @@ func validatorsAreWithdrawn(ec *e2etypes.EvaluationContext, conns ...*grpc.Clien
if err != nil {
return err
}
if bal != 0 {
// Only return an error if the validator has more than 1 eth
// in its balance.
if bal > 1*params.BeaconConfig().GweiPerEth {
return errors.Errorf("Validator index %d with key %#x hasn't withdrawn. Their balance is %d.", valIdx, key, bal)
}

Expand Down

0 comments on commit 299247f

Please sign in to comment.