Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock pending block queue if insertion errors #11600

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Unlock pending block queue if insertion errors #11600

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0605b14
Unlock pending queue if insertion errors
terencechain Nov 2, 2022
59a0216
@saolyn's feedback
terencechain Nov 2, 2022
07534a3
Merge branch 'develop' into pending-queue-unlock
terencechain Nov 2, 2022
eb995d4
Merge branch 'develop' into pending-queue-unlock
prestonvanloon Nov 2, 2022
b7da0f0
Merge refs/heads/develop into pending-queue-unlock
prylabs-bulldozer[bot] Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion beacon-chain/sync/rpc_beacon_blocks_by_root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ func (s *Service) sendRecentBeaconBlocksRequest(ctx context.Context, blockRoots
return err
}
s.pendingQueueLock.Lock()
defer s.pendingQueueLock.Unlock()
if err := s.insertBlockToPendingQueue(blk.Block().Slot(), blk, blkRoot); err != nil {
return err
}
s.pendingQueueLock.Unlock()
return nil
})
return err
Expand Down