Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock pending block queue if insertion errors #11600

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Unlock pending block queue if insertion errors #11600

merged 5 commits into from
Nov 2, 2022

Conversation

terencechain
Copy link
Member

While working on 4844, I noticed when insertBlockToPendingQueue errors out, pendingQueueLock lock still holds. We should be releasing the lock

@terencechain terencechain added the Ready For Review A pull request ready for code review label Nov 2, 2022
@terencechain terencechain self-assigned this Nov 2, 2022
@terencechain terencechain requested a review from a team as a code owner November 2, 2022 01:30
saolyn
saolyn requested changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@saolyn saolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to request change

saolyn
saolyn approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@saolyn saolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prylabs-bulldozer prylabs-bulldozer bot merged commit e4b2b1e into develop Nov 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the pending-queue-unlock branch November 2, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saolyn saolyn saolyn approved these changes

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

@symbolpunk symbolpunk Awaiting requested review from symbolpunk symbolpunk is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terencechain @saolyn @prestonvanloon