Use fieldparams in native beacon state
#10010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
requested review from
prestonvanloon,
nisdas and
uncdr
and removed request for
a team
rkapka
force-pushed
the
use-fieldparams
branch
from
4c5af1d to
66dc608
Compare
rkapka
force-pushed
the
use-fieldparams
branch
from
66dc608 to
d719156
Compare
rkapka
commented
Dec 13, 2021
| replace github.com/ferranbt/fastssz => github.com/rkapka/fastssz v0.0.0-20211206091400-1f383ee9d24e | ||
| replace github.com/ferranbt/fastssz => github.com/rkapka/fastssz v0.0.0-20211213111916-a227cae6be40 |
There was a problem hiding this comment.
I had to fix fastssz to allow constant array lenghts defined in other packages.
rkapka
force-pushed
the
use-fieldparams
branch
from
0ed5d36 to
ad97090
Compare
nisdas
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Refactoring
What does this PR do? Why is it needed?
Make use of constants introduced in #10007
Which issues(s) does this PR fix?
Part of #9820