Use Static Sizes for State Fields #10007
Conversation
| // +build !minimal | ||
|
|
||
| package field_params | ||
|
|
||
| const ( | ||
| BlockRootsLength = 8192 // SLOTS_PER_HISTORICAL_ROOT | ||
| StateRootsLength = 8192 // SLOTS_PER_HISTORICAL_ROOT | ||
| RandaoMixesLength = 65536 // EPOCHS_PER_HISTORICAL_VECTOR | ||
| HistoricalRootsLength = 16777216 // HISTORICAL_ROOTS_LIMIT | ||
| ValidatorRegistryLimit = 1099511627776 // VALIDATOR_REGISTRY_LIMIT | ||
| Eth1DataVotesLength = 2048 // SLOTS_PER_ETH1_VOTING_PERIOD | ||
| PreviousEpochAttestationsLength = 4096 // MAX_ATTESTATIONS * SLOTS_PER_EPOCH | ||
| CurrentEpochAttestationsLength = 4096 // MAX_ATTESTATIONS * SLOTS_PER_EPOCH | ||
| SlashingsLength = 8192 // EPOCHS_PER_SLASHINGS_VECTOR | ||
| SyncCommitteeLength = 512 // SYNC_COMMITTEE_SIZE | ||
| ) |
There was a problem hiding this comment.
We can name this file mainnet.go. It's less verbose, and the folder name already implies field_parameters
There was a problem hiding this comment.
Some more options:
config/params/state_fields/mainnet.go
config/fieldparams/mainnet.go
No strong opinion
config/fieldparams/BUILD.bazel
Outdated
| srcs = [ | ||
| "mainnet.go", | ||
| "minimal.go", #keep | ||
| ], |
There was a problem hiding this comment.
One thing that will have to change is we can no longer include both files in the build with # keep because of SSZ generation for the native beacon state (I think it will pick the first value it finds). There is a "better" way to do this which selects one file based on the current config. You might want to incorporate it into your PR. If not, I will change it in my feature branch.
https://discord.com/channels/476244492043812875/550365651118850081/915341315661778946
There was a problem hiding this comment.
The Discord message has a bug, the second config should have name = "minimal"
…eth-sharding into staticFieldSizes
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
fields we use parameters which can be modified at runtime. If we are running specialized devnets, the state root
computation can differ from what is expected if these parameters are different. This PR adds those fields as constants so that they are never able to change in value.
Which issues(s) does this PR fix?
N.A
Other notes for review