-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polkadot chains: allow arbitrary XCM execution #345
Merged
fellowship-merge-bot
merged 4 commits into
polkadot-fellows:main
from
acatangiu:execute-arbitrary-xcm-polkadot
Jun 24, 2024
Merged
polkadot chains: allow arbitrary XCM execution #345
fellowship-merge-bot
merged 4 commits into
polkadot-fellows:main
from
acatangiu:execute-arbitrary-xcm-polkadot
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following polkadot-fellows#261 where arbitrary XCM execution was enabled on Kusama chains, this commit enables the same for Polkadot chains. Allowing `XcmExecuteFilter = Everything` is considered safe at this point, and doing so greatly increases the usability of these chains since many custom actions can be done through XCM without needing specialized calls for them anymore. This is also a major step in improving dApps integration as they can now interact uniformly with multiple chains, directly using XCM programs. Signed-off-by: Adrian Catangiu <[email protected]>
This was referenced Jun 7, 2024
eskimor
approved these changes
Jun 17, 2024
…ute-arbitrary-xcm-polkadot
Review required! Latest push from author must always be reviewed |
IkerAlus
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared against https://github.com/polkadot-fellows/runtimes/pull/261/files and it LGTM.
seadanda
approved these changes
Jun 18, 2024
bkchr
approved these changes
Jun 24, 2024
/merge |
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit Jun 24, 2024
5330501
into
polkadot-fellows:main
39 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #261 where arbitrary XCM execution was enabled on Kusama chains, this commit enables the same for Polkadot chains.
Allowing
XcmExecuteFilter = Everything
is considered safe at this point, and doing so greatly increases the usability of these chains since many custom actions can be done through XCM without needing specialized calls for them anymore.This is also a major step in improving dApps integration as they can now interact uniformly with multiple chains, directly using XCM programs.