kusama chains: allow arbitrary XCM execution #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIK xcm execution on the relay chain was always safe? On the parachains the problem was just around proof size, which should now be fixed and we could actually enable arbitrary xcm on the parachains. |
acatangiu
force-pushed
the
xcm-execute-filter-fix
branch
from
078273a to
ca76439
Compare
acatangiu
changed the title
We also have |
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
We are exploring [allowing this for Kusama](polkadot-fellows/runtimes#261) as well, disallowing on test chains seems unnecessarily limiting.
joepetrowski
approved these changes
Apr 9, 2024
Merged
1 task
10 tasks
muharem
approved these changes
May 6, 2024
acatangiu
force-pushed
the
xcm-execute-filter-fix
branch
from
ca76439 to
18e9fb3
Compare
|
/merge |
fellowship-merge-bot
bot
merged commit 5a50c5a
into
polkadot-fellows:main
36 checks passed
|
Enabled Available commands
For more information see the documentation |
acatangiu
added a commit
to acatangiu/runtimes
that referenced
this pull request
Jun 7, 2024
Following polkadot-fellows#261 where arbitrary XCM execution was enabled on Kusama chains, this commit enables the same for Polkadot chains. Allowing `XcmExecuteFilter = Everything` is considered safe at this point, and doing so greatly increases the usability of these chains since many custom actions can be done through XCM without needing specialized calls for them anymore. This is also a major step in improving dApps integration as they can now interact uniformly with multiple chains, directly using XCM programs. Signed-off-by: Adrian Catangiu <[email protected]>
This was referenced Jun 7, 2024
fellowship-merge-bot bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
Following #261 where arbitrary XCM execution was enabled on Kusama chains, this commit enables the same for Polkadot chains. Allowing `XcmExecuteFilter = Everything` is considered safe at this point, and doing so greatly increases the usability of these chains since many custom actions can be done through XCM without needing specialized calls for them anymore. This is also a major step in improving dApps integration as they can now interact uniformly with multiple chains, directly using XCM programs. --------- Signed-off-by: Adrian Catangiu <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kusama relay is the only chain here allowing arbitrary XCM execution.
This was enabled in paritytech/polkadot#4809 for (afaict) allowing crafting and executing XCM DOT transfers. Now, these are done through dedicated extrinsics and manual
pallet_xcm::executeis not required (for transfers at least).AFAICT, allowing
Everythingon Kusama should also be safe at this point (XCM is pretty mature) and fosters experimentation and more flexibility on Kusama. But in that case, maybe we should also allow it on Kusama system chains?Thoughts?