fix Encointer CI #330
Merged
fix Encointer CI #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
approved these changes
May 27, 2024
There was a problem hiding this comment.
Oh, its not a CI failure 😅
I use FAIL-CI similar to a TODO, but it makes the CI fail - so we never merge before fixing all of them.
My only question was about this ResolveTo<StakingPotAccountId code, that i just copied from the other runtimes. If it looks good to you then we can close.
|
Review required! Latest push from author must always be reviewed |
|
thanks for double-checking. KSM fees should now be treated exactly like for AH. So I guess it's fine if it works for AH I suggest to merge this anyway as it will remove a warning and a TODO comment. up to you @ggwpez |
ggwpez
merged commit a76335d
into
polkadot-fellows:oty-update-sdk
12 of 35 checks passed
|
Okay thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ggwpez unfortunately, I couldn't find CI logs showing the error you want me to resolve.
However, I assume the unused/deprecated warning would certainly disturb CI, so I started by fixing that one. Please let me know if you need more fixes, pointing me to the error you observe