Update to SDK 1.13 #322

ggwpez · 2024-05-22T00:26:56Z

Updates the runtimes from 1.7 to 1.13.

TODO:

Wait for 1.13 crates release and integrate them.
Fix all FAIL-CI @name.
Enable Encointer runtimes and pallets once they are on 1.13 as well @brenzi.
Unrevert #337

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

system-parachains/bridge-hubs/bridge-hub-kusama/src/lib.rs

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

…ate-sdk

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez · 2024-05-22T16:32:51Z

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

+		AccountId,
+		Self::AssetKind,
+		PoolIdToAccountId,
+	>; // FAIL-CI @muharem does this make sense or do we need the AccountIdConverter?


@muharem i copied this from the SDK, please check.

for Kusama we need to leave it with no seed for now (AccountIdConverterNoSeed) to keep the same derivation as now. to migrate to new derivation, we need to include the migration pallet. I can do it in separate PR, this is not critical.

in Polkadot Asset Hub, for the same type parameter we can use this setup, and remove the imps::pool module. this is because for the pallet for Polkadot was launched with the new derivation.

Not sure if i understood this correctly, but i could not get it to compile with the changes.
Can you please just push a commit here to fix it?

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

system-parachains/people/people-polkadot/src/lib.rs

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

CHANGELOG.md

acatangiu

Everything looks good (modulo some config where @muharem is tagged to check, where I did not verify in-depth).

Thank you @ggwpez ! 🚀

relay/kusama/src/weights/pallet_xcm.rs

relay/kusama/src/xcm_config.rs

relay/polkadot/src/weights/pallet_xcm.rs

relay/polkadot/src/xcm_config.rs

system-parachains/asset-hubs/asset-hub-kusama/src/weights/pallet_xcm.rs

system-parachains/collectives/collectives-polkadot/src/xcm_config.rs

system-parachains/coretime/coretime-kusama/src/xcm_config.rs

system-parachains/encointer/src/xcm_config.rs

system-parachains/people/people-kusama/src/xcm_config.rs

system-parachains/people/people-polkadot/src/xcm_config.rs

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

bkchr

IdleMaxServiceWeight is set everywhere to nothing. Was this done on purpose?

CHANGELOG.md

bkchr · 2024-07-04T13:05:58Z

CHANGELOG.md

@@ -6,9 +6,90 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

 ## [Unreleased]

+### Added
+
+- [[#322](https://github.com/polkadot-fellows/runtimes/pull/322)] Add `claim_assets` extrinsic to `pallet-xcm` ([SDK v1.9 #3403](https://github.com/paritytech/polkadot-sdk/pull/3403)).


Not sure about the formatting. Maybe having the pr only once and then mention all these changes in a sublist?

Grouped them now.

bkchr · 2024-07-04T13:07:17Z

CHANGELOG.md

+- [[#322](https://github.com/polkadot-fellows/runtimes/pull/322)] Im-online pallet offchain storage cleanup ([SDK v1.8 #2290](https://github.com/paritytech/polkadot-sdk/pull/2290)).
+- [[#322](https://github.com/polkadot-fellows/runtimes/pull/322)] Implements a percentage cap on staking rewards from era inflation ([SDK v1.8 #1660](https://github.com/paritytech/polkadot-sdk/pull/1660)).
+- [[#322](https://github.com/polkadot-fellows/runtimes/pull/322)] Introduce submit_finality_proof_ex call to bridges GRANDPA pallet ([SDK v1.8 #3225](https://github.com/paritytech/polkadot-sdk/pull/3225)).
+- [[#322](https://github.com/polkadot-fellows/runtimes/pull/322)] Multi-Block-Migrations, `poll` hook and new System Callbacks ([SDK v1.9 #1781](https://github.com/paritytech/polkadot-sdk/pull/1781)).


Suggested change

- [[#322](https://github.com/polkadot-fellows/runtimes/pull/322)] Multi-Block-Migrations, `poll` hook and new System Callbacks ([SDK v1.9 #1781](https://github.com/paritytech/polkadot-sdk/pull/1781)).

Not exactly sure how you have compiled this list, however these are not changes that are relevant to the upstream users.

I tried out a script and the deleted uninteresting ones manually, but looks like i have to delete some more.

Maybe we can just directly include this script in the release process?

The script only helps only when updating to a new SDK version.
But in theory we could also copy the relevant prdoc files from the SDK into the runtimes repo and then aggregate them on release.

CHANGELOG.md

relay/kusama/src/lib.rs

bkchr · 2024-07-04T13:39:14Z

relay/polkadot/src/lib.rs

@@ -1929,6 +1941,9 @@ pub mod migrations {
 			ImOnlinePalletName,
 			<Runtime as frame_system::Config>::DbWeight,
 		>,
+		parachains_configuration::migration::v12::MigrateToV12<Runtime>,


We should clean up the migrations.

Removed all the old ones from Kusama and Polkadot now here: 515b383
There are probably still some in the SPs, but can do afterwards.

bkchr · 2024-07-04T13:43:30Z

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

+	// Most on-chain HRMP channels are configured to use 102400 bytes of max message size, so we
+	// need to set the page size larger than that until we reduce the channel size on-chain.


Is there a proposal for this or when will this be done?

No proposal yet, probably need to do paritytech/polkadot-sdk#3145 first.

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs

system-parachains/asset-hubs/asset-hub-polkadot/src/impls.rs

Co-authored-by: Adrian Catangiu <[email protected]>

Co-authored-by: Bastian Köcher <[email protected]>

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

…polkadot_config.rs Co-authored-by: Adrian Catangiu <[email protected]>

…o_kusama_config.rs Co-authored-by: Adrian Catangiu <[email protected]>

…rc/lib.rs Co-authored-by: Adrian Catangiu <[email protected]>

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Kusama pool address locator has no pallet id seed in it. Polkadot pool locator uses type from sdk.

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

brenzi and others added 17 commits May 21, 2024 13:20

upgrade encointer deps to sdk 1.11

b525994

Update to 1.8

59018dc

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update weight files manually

36ae226

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Disable encointer runtimes until their ready

fd57517

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Tests: Update trait bounds

b558191

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update runtimes

b5e3ebe

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Disable broken test

a4c15a5

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update to 1.9

ca20d4d

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update weight files

bafbd1e

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update runtimes

55574a8

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update to 1.10

d09bfee

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Fix weights

4accc57

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update runtimes

8e88128

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Mock integration tests to make the compile

3d8d887

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update to 1.11

9f77fd4

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update weights

85f9619

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update runtimes to 1.11

6ebb73d

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez commented May 22, 2024

View reviewed changes

system-parachains/bridge-hubs/bridge-hub-kusama/src/lib.rs Show resolved Hide resolved

ggwpez added 11 commits May 22, 2024 12:34

Merge remote-tracking branch 'origin/main' into oty-update-sdk

1dfef22

Update lockfile

d535724

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

snowbridge: Remove unstuck logic

467031a

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Make stuff compile

d7e6026

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Merge branch 'ab/upgrade-encointer-pallets-for-sdk-1-11' into oty-upd…

a1b1736

…ate-sdk

Re-enable Encointer runtimes

6e6e8ac

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Re-enable encointer runtimes

33422be

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

fmt

88c0c8c

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Merge remote-tracking branch 'origin/main' into oty-update-sdk

2ae9541

Mention github handles

2bdb3a0

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

fmt

3eed9e5

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez commented May 22, 2024

View reviewed changes

ggwpez added 2 commits July 2, 2024 15:22

Merge branch 'main' into oty-update-sdk

46c748f

Cleanup and CHANGELOG

0ad5425

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

joepetrowski reviewed Jul 2, 2024

View reviewed changes

system-parachains/people/people-polkadot/src/lib.rs Outdated Show resolved Hide resolved

Identity origins

6569fbd

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

acatangiu reviewed Jul 3, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

acatangiu approved these changes Jul 3, 2024

View reviewed changes

Changelog

b90443e

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

bkchr approved these changes Jul 4, 2024

View reviewed changes

ggwpez and others added 14 commits July 4, 2024 22:48

Disable XcmRecorder

9e8577d

Co-authored-by: Adrian Catangiu <[email protected]>

Update CHANGELOG

117f607

Co-authored-by: Bastian Köcher <[email protected]>

Apply suggestions from code review

f42dcbb

Co-authored-by: Bastian Köcher <[email protected]>

use sublist for 322

42f2f88

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Set MQ idle weight to 20% of block

a38d905

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

tabs

ec1b675

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update system-parachains/bridge-hubs/bridge-hub-kusama/src/bridge_to_…

52df96c

…polkadot_config.rs Co-authored-by: Adrian Catangiu <[email protected]>

Update system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_t…

16d089d

…o_kusama_config.rs Co-authored-by: Adrian Catangiu <[email protected]>

Update system-parachains/bridge-hubs/bridge-hub-polkadot/primitives/s…

57121fd

…rc/lib.rs Co-authored-by: Adrian Catangiu <[email protected]>

Kusama,Polkadot: Remove old migrations

515b383

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Merge remote-tracking branch 'origin/main' into oty-update-sdk

e75b9a7

Bring all deps back to 1.13

7dd8f47

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Remove old host config defaults

4285a03

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Merge branch 'main' into oty-update-sdk

43dd4fd

skunert approved these changes Jul 9, 2024

View reviewed changes

Pool Fixes to SDK 1.13 update (#378)

5dbb7e1

Kusama pool address locator has no pallet id seed in it. Polkadot pool locator uses type from sdk.

seadanda approved these changes Jul 11, 2024

View reviewed changes

ggwpez added 2 commits July 11, 2024 12:46

Fix compile

60f67c3

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Remove FAIL-CI

b5e0cda

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez merged commit c5080e4 into main Jul 11, 2024
45 checks passed

ggwpez deleted the oty-update-sdk branch July 11, 2024 14:07

seadanda mentioned this pull request Aug 3, 2024

Enable Coretime on Polkadot Relay #401

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to SDK 1.13 #322

Update to SDK 1.13 #322

ggwpez commented May 22, 2024 •

edited

Loading

ggwpez May 22, 2024

muharem May 23, 2024

muharem May 23, 2024

ggwpez Jun 25, 2024

acatangiu left a comment

bkchr left a comment

bkchr Jul 4, 2024

ggwpez Jul 4, 2024

bkchr Jul 4, 2024

ggwpez Jul 4, 2024

bkchr Jul 4, 2024

ggwpez Jul 4, 2024 •

edited

Loading

bkchr Jul 4, 2024

ggwpez Jul 4, 2024 •

edited

Loading

bkchr Jul 4, 2024

ggwpez Jul 4, 2024

		// Most on-chain HRMP channels are configured to use 102400 bytes of max message size, so we
		// need to set the page size larger than that until we reduce the channel size on-chain.

Update to SDK 1.13 #322

Update to SDK 1.13 #322

Conversation

ggwpez commented May 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acatangiu left a comment

Choose a reason for hiding this comment

bkchr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ggwpez Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ggwpez Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ggwpez commented May 22, 2024 •

edited

Loading

ggwpez Jul 4, 2024 •

edited

Loading

ggwpez Jul 4, 2024 •

edited

Loading