Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Identity from Kusama Relay #315

Merged
merged 28 commits into from
Jun 11, 2024
Merged

Remove Identity from Kusama Relay #315

merged 28 commits into from
Jun 11, 2024

Conversation

joepetrowski
Copy link
Contributor

As a follow up to the migration to a People Chain, we can remove everything Identity-related from the Relay Chain.

joepetrowski
joepetrowski commented May 18, 2024
View reviewed changes
relay/kusama/src/lib.rs Outdated Show resolved Hide resolved
ggwpez
ggwpez reviewed May 22, 2024
View reviewed changes
relay/kusama/src/lib.rs Outdated Show resolved Hide resolved
@joepetrowski joepetrowski mentioned this pull request May 22, 2024
Closed
7 tasks
@github-actions GitHub Actions
Copy link

Review required! Latest push from author must always be reviewed

@github-actions github-actions bot requested a review from ggwpez May 22, 2024 17:04
@github-actions GitHub Actions
Copy link

Review required! Latest push from author must always be reviewed

@github-actions github-actions bot requested a review from zjb0807 May 29, 2024 12:57
acatangiu
acatangiu approved these changes May 30, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
relay/kusama/src/lib.rs Show resolved Hide resolved
@joepetrowski @acatangiu
Update CHANGELOG.md
e0d600e 
Co-authored-by: Adrian Catangiu <[email protected]>
muharem
muharem reviewed May 30, 2024
View reviewed changes
relay/kusama/src/lib.rs Outdated Show resolved Hide resolved
bkchr
bkchr approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, otherwise looks good.

relay/kusama/src/lib.rs Show resolved Hide resolved
@joepetrowski
Copy link
Contributor Author

/merge

@joepetrowski
Copy link
Contributor Author

/merge cancel

acatangiu
acatangiu suggested changes May 30, 2024
View reviewed changes
relay/kusama/src/lib.rs Show resolved Hide resolved
@joepetrowski
Copy link
Contributor Author

Actually this is missing one thing (thanks try-runtime). We need to kill/update all Identity Judgement proxies (and should have included that in the migration to the parachain).

@fellowship-merge-bot fellowship-merge-bot bot disabled auto-merge May 30, 2024 11:58
@fellowship-merge-bot
Copy link
Contributor

Disabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@joepetrowski
Copy link
Contributor Author

joepetrowski commented May 31, 2024 •
edited
Loading

I discovered that we missed something in the migration, some users were in a FeePaid state of awaiting judgement.

So we need to do two things:

  1. Write a Relay Chain migration that unreserves the funds. This was actually handled correctly.
  2. Write a People Chain migration that removes the (registrar_index, FeePaid(Balance)) requests.

People will need to re-request judgement.

Accounts with FeePaid status on the parachain at genesis:

Account: J93MdZPvP1RnQj5va1TaqZNm45t4zvvVEhFJ4MChyerR95b had request: (1, {'FeePaid': 350000000000})
Account: G2bC9gtyHBkxmg65nZiZ7pbrV7PMLNXUTwr6dqMUk8KDxXG had request: (4, {'FeePaid': 40000000000})
Account: EctdZvgkphLJMQmKntaPP74LKpGvDKaj1cbqC8fUT4HzqiC had request: (4, {'FeePaid': 40000000000})
Account: F7otXz5RLDMf1Vcdo98zY4zYWQ13E7yeST48ZRS9QKHdr3d had request: (0, {'FeePaid': 40000000000})
Account: HcKFGbBBrfW6Jp22DMSUL6bTfKtxC23ENfmssgznVd7tzdG had request: (0, {'FeePaid': 40000000000})
Account: DYF9v3ycZ7NEJ44vtxGgQjsNP5agLjMQnwNJUhuEyv4dJdY had request: (1, {'FeePaid': 2200000000000})
Account: J6ixMhTj9UmgZtNiWVGs1SdGm9HXSj7z2Emjc9syMgGdN5X had request: (4, {'FeePaid': 40000000000})
Account: HcABYELeFAsHvFQTwcEJEWgEFtXTmjrKS87ings2BGJ99U4 had request: (0, {'FeePaid': 40000000000})
Account: EkQWFRUHmSt8qCwmgYv8TNSaFu1Xo5DaDAHBZbZZFxXMwDr had request: (5, {'FeePaid': 0})
Account: EoYkgoLQn1GZrJLmqVMd6GhSJYWtYAtzg3fEcWH6nXjscqC had request: (4, {'FeePaid': 40000000000})
Account: Dw5PyH3WKr3QPJSBZHEoAcXQ3RTH5DLfn6LyjAp3e7opvyJ had request: (0, {'FeePaid': 40000000000})
Account: GAEc5zyC41qXDdEVNT2nfCURHp1gT3Ds2STS1vDGSVs5Q5p had request: (0, {'FeePaid': 40000000000})
Account: H4igjSm5x9pRfL7go9NAzbdYcuiyPnWgP7XnvD24UFvNyrb had request: (1, {'FeePaid': 2000000000000})
Account: HsVe9jQaNe32nuXsmuiJ8ZddoifhsHxQdNVpJDssQe6QZTE had request: (0, {'FeePaid': 40000000000})
Account: Etj64GQ5Mzm98HijdnvqjxMyK8xemPtLTpWdnwEiEvFygJa had request: (3, {'FeePaid': 1000000000000})
Account: EcuYcMTbg5xYpTfiF5pYkzeSUp6DdFBty2aYjBaGq5r8GGN had request: (1, {'FeePaid': 4500000000000})
Account: EcuYcMTbg5xYpTfiF5pYkzeSUp6DdFBty2aYjBaGq5r8GGN had request: (2, {'FeePaid': 1000000000000})
Account: DGK8yvCQrw2CFtLU7gGB7RdSTqbTqh6QuMvGeuSFiEFVNMj had request: (1, {'FeePaid': 550000000000})
Account: GcS4cm9Zuk1EYAm3N92TXgUGAhG18Y4g9niZ4Pz1Ak9fu3C had request: (0, {'FeePaid': 40000000000})
Account: EG3ALR9v1fnwJDZXMgpbumADoFp9Ms4TFL1DipQ2FFZo7fc had request: (4, {'FeePaid': 40000000000})
Account: Hk8BuMYD5YwiNkdTNezaLhejHHU7ERfydrK5mEhCk9CLg8p had request: (1, {'FeePaid': 1150000000000})
Account: Ft54drAPiKA6SKrnvHju9ufEJ5RayG1XdKPoeESYhLDL1Fg had request: (3, {'FeePaid': 1000000000000})
Account: HxypL9kbLv6YSqtzNZzE8PHbSahnwjYMooPD5YgopfGPdux had request: (0, {'FeePaid': 40000000000})
Account: FniUEiBUWBwsFB69JjYGNxTk2QXWtvS4GvZm2WviE5jvF8J had request: (4, {'FeePaid': 40000000000})
Account: Hk7KEABB7oQsDcrRwDYwVw5FUbmDXsHLUqR8QrcfcTsL7CG had request: (0, {'FeePaid': 40000000000})
Account: CfjysLC6eAcQw7RvnJYYDmXUrvpmBpHaVR9RDbRw9xu9enb had request: (0, {'FeePaid': 40000000000})
Account: J19LYGghRCe4Ct3VW4Vz1amMoUgogS1sh2FQvPWroKcDdb1 had request: (2, {'FeePaid': 1000000000000})
Account: FX89aERv2qbWRX5kVuTvEYHq4JfRvZqVvihKgcwYkkQcdfd had request: (0, {'FeePaid': 40000000000})
Account: CeDRtNAtLARL4XrErR1ZwTXhzrfLHPCXonn6yZiw428YNvA had request: (0, {'FeePaid': 40000000000})
Account: EPrEfsCZQtKt3Cp3vx6BSE4d9ACxMWTN2E5kQBRe612WpL2 had request: (0, {'FeePaid': 40000000000})
Account: DG6egJCfrcNPMSFYihxxPxtWvMwq3GR5k3pUS4pHouamuTv had request: (1, {'FeePaid': 4500000000000})
Account: E3BajuRoG9Wv7RQW6s5vtqMZkLk2khDPjgzVXRwXdd913Uw had request: (0, {'FeePaid': 40000000000})
Account: E3BajuRoG9Wv7RQW6s5vtqMZkLk2khDPjgzVXRwXdd913Uw had request: (2, {'FeePaid': 1000000000000})
Account: JL67WnG2nhCr7SLAvz7v9q8vc7vmoEpgBSLCyYAbrCxniwK had request: (0, {'FeePaid': 40000000000})
Account: FHfsuLeg7fNE3GKHyH1Pumcrf5qQdLWRYpfMe8jyESX7uEi had request: (1, {'FeePaid': 1150000000000})
Account: EawkLpK68LU4b4DPoJsoCrEaMNAufT5Wj3oXbhvYLfQFNEi had request: (0, {'FeePaid': 40000000000})
Account: HJ4UFo54JQXA6jcYtE442uPVbTtJyMtNqz4GGymnjixBAsw had request: (4, {'FeePaid': 40000000000})
Account: DrM2WzmbZCpfpKDox8GxRZTa32rqjBok26GxuemdDTmGhic had request: (0, {'FeePaid': 40000000000})
Account: EwAM83Dsj1AvGbT9SyqZRDNAgJ7uzriEvkjckKYiVL5BcAa had request: (0, {'FeePaid': 40000000000})
Account: HC7FK5TNgUrdA8L3P3g4tU6s5axJpjsXr7oYArejv6Vjadh had request: (4, {'FeePaid': 40000000000})
Account: Hc4772chcQ4bSTjbQ5RW2vunCSDhg3PqpRLiNoT4yTW6J3P had request: (1, {'FeePaid': 350000000000})
Account: HiREGkafbanLjQRKgfn3r9MWfnj36oy58wVjvxSwaEUmitw had request: (1, {'FeePaid': 5000000000000})
Account: HFfY9N5mHFr4Fhm1gQnKHEy4oSk5UeTCxYkymy9yvVKuSLM had request: (0, {'FeePaid': 40000000000})
Account: Hss64YRSDjDAbikNatbaQJeq1kCa7Dc6SrDhtW8zah4eKS8 had request: (0, {'FeePaid': 40000000000})
Account: EiP5dzgmh5SvqVqzXj35XomK34WSCNqyv4BPEdKtASDD8JU had request: (0, {'FeePaid': 40000000000})
Account: ESCuhnrkwA5xNKKNqsaswSNqGhEtaMNGPyrcXnj8uLPtzxe had request: (0, {'FeePaid': 40000000000})
Account: EDx9omQA9Gg18d63xugKrpW1oq66VcaXe2KYTRdM5djhdsY had request: (4, {'FeePaid': 40000000000})
Account: FUvoPp5BwXWxhMvhdDNaXoYnyRZuXWoZ1UTQkEJMqqM8MPv had request: (0, {'FeePaid': 40000000000})
Account: D2fQba1g6ngMAzZ7iwoZiWYjYfDW4iX8yLLxBNMHV1xn6BF had request: (0, {'FeePaid': 40000000000})
Account: Dp48NU5neehWT625WMo2TGSnsQ2Z2yFXvKfUAkMFZymVQ4z had request: (0, {'FeePaid': 40000000000})
Account: EocabFvqttEamwQKoFyQxLPnx9HWDdVDS9wwrUX1aKKbJ5g had request: (0, {'FeePaid': 40000000000})
Account: EQMEjKaA8TUuqah52Z7GwHmy8XG1RwXWynLoLuFmyPEoRUW had request: (0, {'FeePaid': 40000000000})
Account: HkHdMDkuPUh7xyJ6UG3Hh1P5J5qfLbgrSbXbVCkGhVTNJjV had request: (0, {'FeePaid': 40000000000})
Account: HD3uoRSHiGftXfWe31Gp44yezjuaqfRX5izjg3k2wSYoCTd had request: (0, {'FeePaid': 40000000000})
Account: JLJWkHMzAedfCeJSGXVcwEdTbUdbDRDvphRLHeqhmPVJoGy had request: (0, {'FeePaid': 40000000000})
Account: HsFee3QAwYrE4oiYGTjQvXQYCaxN5BTLKgJRwVNPZoYzxKE had request: (0, {'FeePaid': 40000000000})
Account: DbBvwpiGWrAJUQo1gYChwJte3YQ2syDJwbtT7wZKnFAobcC had request: (1, {'FeePaid': 550000000000})
Account: H1j5tYoXRSmeh4SGdSNV3NjHstyeLa6ENYhJx1eZJGroTN4 had request: (0, {'FeePaid': 40000000000})
Account: EVAbzBJcQvGndsDrv19ENVxnEmYNkMxNRhDXPWxSfH8bQMX had request: (4, {'FeePaid': 40000000000})
Account: G2pHe6DJN78JZBo5cfgsX3MXVKdHxcitP35JtMquVxWNVQj had request: (4, {'FeePaid': 40000000000})
Account: HEHnVm4i3RAnayTtU7J7nqQjUvUkf6Vp4ckMB8mSX8vyV5P had request: (0, {'FeePaid': 40000000000})
Account: Dj2APSo6cz77hZUrViHktQ1Ze8PppeT9Yff1yAb9n5wpa8V had request: (0, {'FeePaid': 40000000000})
Account: Dj2APSo6cz77hZUrViHktQ1Ze8PppeT9Yff1yAb9n5wpa8V had request: (4, {'FeePaid': 40000000000})
Account: GLdbdQ1E5kM73RN6d8Z1SW7auyneEpp99rxp49ziDaz535B had request: (0, {'FeePaid': 40000000000})
Account: EDit4LEaMTJn8RzfqeASLU4CeQiTRzP8xF96s4yLrzWVn6B had request: (0, {'FeePaid': 40000000000})
Account: G7Ur4BnMSfP2qE7ruSob5gwGQ5nzkGWu7Yqh14FcMqnDtgB had request: (2, {'FeePaid': 0})
Account: GCykiMRtfpCAaiKo14tz3Da9TtqDhZmeC7Hsxy4tPuqMftx had request: (0, {'FeePaid': 40000000000})
Account: EGU1mTpaHKdwqXJwZGSmyEhuh1Exy2o4yd6UyJ9HcGfBsjN had request: (4, {'FeePaid': 40000000000})
Account: HKirEeY7XuHKKeC6qNBQ3aUT3tEWdoVDKxmNoqxKpALVbg8 had request: (0, {'FeePaid': 40000000000})
Account: GqjkVUq15XtU6Njj8BjzkDFkmSnSnGeCbaucPcvp9ZNfXNT had request: (0, {'FeePaid': 40000000000})
Account: GqjkVUq15XtU6Njj8BjzkDFkmSnSnGeCbaucPcvp9ZNfXNT had request: (4, {'FeePaid': 40000000000})
Account: Eo4gFWxGEgzaYocmGbin8FnUxTTw5Pojxh5AsAjQtApEtnM had request: (0, {'FeePaid': 40000000000})
Account: Ci1wNS8S61ebNUbZeXgSoJG48unjC42RiYd2WmFJCaey83B had request: (5, {'FeePaid': 0})
Account: F7YkUTr9hpnxqmg4ReC8zmkBC9uBUgNFnjS71qeyv8ZbjHx had request: (0, {'FeePaid': 40000000000})
Account: Cgg88kqUoak7py4h8VzE6Hm1qQqoYbuuWoi3NLruYVne9xs had request: (1, {'FeePaid': 2200000000000})
Account: FczL661VujsMFqZT32Y3iBmNpSxUw4gMnq2JtdoFT6rJzr4 had request: (0, {'FeePaid': 40000000000})
Account: Gesjrqrw5fVZhrG4vFJE2YM3RoXLekHX8ZSkLgYjbtAVN2B had request: (1, {'FeePaid': 550000000000})
Account: GNoDBVkKjvueoJWE8eXAkjTW83SWuS9rKXKGC3LfTFaJtiX had request: (4, {'FeePaid': 40000000000})
Account: FZjF6UzE9nzcksuJ9qiaqRgkWcfuHvd9rg87ncQFyW3RosZ had request: (0, {'FeePaid': 40000000000})
Account: E5djM6u2p67C1LfkSyNDfRnvYwg6HAQxwPB8yK6Q5eAwdjn had request: (0, {'FeePaid': 40000000000})
Account: Gh2NseZYaC16E7LZJU3K1TbEcZbVUritBRWfYrmf6s8hxi9 had request: (0, {'FeePaid': 40000000000})
Account: EAHKnvCtUq4QDg2f6cSeYhvjJt93VWM5rvHKuqvAwkdp4RV had request: (0, {'FeePaid': 40000000000})
Account: CwxT1UBP5nDxTkJfcptVn9rgV7AinGUqgJpcNTT9Um32xmj had request: (4, {'FeePaid': 40000000000})
Account: DShgED7MWc9UrfcoofsFAcK6YJqRHpMYcfDk5odpM2C34FF had request: (0, {'FeePaid': 40000000000})
Account: FQ11qFsooitS49a5aWGJGy2q9kAo1ZG77wnaDFUm1NhSJbC had request: (0, {'FeePaid': 40000000000})
Account: D134isLWbuR8wxrGPsBuHmtqHFVjgVXNPnoN1e9zPJ7hq3P had request: (0, {'FeePaid': 40000000000})
Account: Gy2SSkZWXq3jHwmSEBSpqVpKN8cWEAECwKnvS7j3srV7sZ9 had request: (1, {'FeePaid': 1150000000000})
Account: F5UikwyqfW8nAqud3DC9N1sq65Hpr8zPnsHcqqyNAfmzRqR had request: (0, {'FeePaid': 40000000000})
Account: DaUR7Puu8u3PRw1Xha1in2s55bYXmbv4tX8ETe4gfvXEd32 had request: (0, {'FeePaid': 40000000000})
Account: FkZ9HmeRhqUzp7VAozvhJcvbMff7HcV4zHwiYqYVhxV7kFh had request: (0, {'FeePaid': 40000000000})

Script to reproduce:

# https://polkascan.github.io/py-substrate-interface/getting-started/installation/
from substrateinterface import SubstrateInterface

chain = SubstrateInterface(
	url="wss://kusama-people-rpc.polkadot.io"
)

print(f"Connected to {chain.name}: {chain.chain} v{chain.version}")

# Genesis Hash
block_hash = "0xc1af4cb4eb3918e5db15086c0cc5ec17fb334f728b7c65dd44bfe1e174ff8b3f"
query = chain.query_map('Identity', 'IdentityOf', block_hash=block_hash)

for acc, ii in query:
	for jj in ii.value[0]['judgements']:
		if isinstance(jj[1], dict) and 'FeePaid' in jj[1].keys():
			print(f"Account: {acc} had request: {jj}")

@liamaharon liamaharon mentioned this pull request Jun 2, 2024
Merged
@muharem muharem mentioned this pull request Jun 3, 2024
Merged
@muharem
Copy link
Contributor

muharem commented Jun 3, 2024

a call to clean up the wrong judgement requests #339

@joepetrowski joepetrowski mentioned this pull request Jun 6, 2024
Closed
4 tasks
joepetrowski
joepetrowski commented Jun 11, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@joepetrowski
Copy link
Contributor Author

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 5084967 into polkadot-fellows:main Jun 11, 2024
37 of 38 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@joepetrowski joepetrowski deleted the remove-kusama-relay-identity branch June 11, 2024 15:33
fellowship-merge-bot bot pushed a commit that referenced this pull request Jun 13, 2024
@muharem @bkontur @joepetrowski
Kusama People: Clear judgements (#339)
cede94a 
Clear requested judgements that do not have corresponding deposits
reserved.

These judgements exist because the data migration did not take into
consideration the deposits for requested judgements.

More info:
#315 (comment)

---------

Co-authored-by: Branislav Kontur <[email protected]>
Co-authored-by: joe petrowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu requested changes

@ggwpez ggwpez ggwpez approved these changes

@bkontur bkontur bkontur approved these changes

@muharem muharem muharem approved these changes

@bkchr bkchr bkchr approved these changes

@zjb0807 zjb0807 Awaiting requested review from zjb0807

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@joepetrowski @muharem @bkchr @bkontur @ggwpez @zjb0807 @acatangiu @liamaharon