v1.2.5 Release

[joepetrowski]

v1.2.5

• Implement CheckMetadataHash extension paritytech/polkadot-sdk#4274 + backports
• Add CheckMetadataHash extension #337
• Bump staking and nomination pools #318
• Filter out credit purchase call #312
• Update Identity Patch #323
• Add establish_channel_with_system to the HRMP pallet #329
• Block Request Judgement Calls on Polkadot #338

[muharem]

It would be nice to include this

• Transaction payments work via new fungible traits implementation #332

[eskimor]

• New broker pallet, draft PR: Adjust to new Broker pallet. #334

[muharem]

@joepetrowski it's not clear with the plan with CheckMetadataHash extension?

[joepetrowski]

@joepetrowski it's not clear with the plan with CheckMetadataHash extension?

We need to bump to the patch releases of these crates: paritytech/polkadot-sdk#4635

[seadanda]

• New broker pallet, draft PR: WIP: Adjust to new Broker pallet. #334

The changes in question depend on a breaking change to the broker pallet in v0.13.0.
To get this into the next release we have to either:

1. update a lot (most?) of the dependencies in the repo
2. backport this breaking change to the broker as a 'fix' to broker 0.7 (based on the 1.7 sdk release)
3. use a git version for the broker pointing to an unreleased version of 2

1 would delay the release by a fair bit, 2 is a pretty bad semver violation and then I know that there is a lot of resistance to 3 being in the codebase.

What are people's opinions on which way is least bad?

[bkchr]

3. use a git version for the broker pointing to an unreleased version of 2

We need to use a patch in the workspace Cargo.toml that uses git.

[acatangiu]

2. backport this breaking change to the broker as a 'fix' to broker 0.7 (based on the 1.7 sdk release)

2 is a pretty bad semver violation

Are there any other users of the broker pallet? Afaik this is pretty new and its usecase is also very specific. It might actually not break anyone.

[seadanda]

There were some unrelated changes in the PR which changed the broker which required a migration, and there is already a broker migration from another commit which has not yet run on coretime-kusama. To avoid messing up storage versions, I've isolated the relevant changes for the price adapter and backported them in this PR.

I'd like a second pair of eyes on it before using it as it wasn't just a straightforward backport. Can re-target the PR onto another branch as needed, and whether we go for option 2 or 3 this should be sufficient.

[muharem]

• Kusama People: Clear judgements #339

[joepetrowski]

• Kusama People: Clear judgements #339

I think this can probably go into 1.2.6 with the other People stuff. We need to prioritize the Coretime changes for 1.2.5 due to the Kusama timeline.

[eskimor]

• Run benchmarks for broker pallet.

[joepetrowski]

• Run benchmarks for broker pallet.

• Weights for 1.2.5 - coretime-kusama + kusama fix for new prefixed with polkadot_runtime_common #343