Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nil session tree logger #1007

Merged
merged 4 commits into from
Dec 12, 2024
Merged

fix: Nil session tree logger #1007

merged 4 commits into from
Dec 12, 2024

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Dec 12, 2024

Summary

This PR initializes the logger of the SessionTree by updating the ensureSessionTree function to pass the logger, and modifying test utilities to support the new logger parameter.

Issue

Type of change

Select one or more from the following:

Testing

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@red-0ne red-0ne added bug Something isn't working relayminer Changes related to the Relayminer labels Dec 12, 2024
@red-0ne red-0ne added this to the Shannon Beta TestNet Support milestone Dec 12, 2024
@red-0ne red-0ne requested a review from Olshansk December 12, 2024 02:15
@red-0ne red-0ne self-assigned this Dec 12, 2024
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please reoder

testutil/testtree/tree.go Outdated Show resolved Hide resolved
testutil/testtree/tree.go Outdated Show resolved Hide resolved
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 1007)
Grafana network dashboard for devnet-issue-1007

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Dec 12, 2024
@red-0ne red-0ne merged commit 938f818 into main Dec 12, 2024
10 checks passed
bryanchriswhite added a commit that referenced this pull request Dec 13, 2024
* fix/e2e/path-path:
  fix: E2E tests - RPC URL path
  Updated cheat sheat docs with an example after installation (#1004)
  fix: Nil session tree logger (#1007)
bryanchriswhite added a commit that referenced this pull request Dec 13, 2024
* pokt/main:
  [Relayminer, Bug] fix: sessiontree logger never initialized (#993)
  fix: E2E tests - RPC URL path (#1008)
  Updated cheat sheat docs with an example after installation (#1004)
  fix: Nil session tree logger (#1007)
@red-0ne red-0ne mentioned this pull request Dec 16, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devnet devnet-test-e2e push-image CI related - pushes images to ghcr.io relayminer Changes related to the Relayminer
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants