Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Investigate RelayMiner Issues #1006

Closed
6 tasks
Olshansk opened this issue Dec 12, 2024 · 1 comment
Closed
6 tasks

[Bug] Investigate RelayMiner Issues #1006

Olshansk opened this issue Dec 12, 2024 · 1 comment
Assignees
@red-0ne
Labels
bug Something isn't working
Milestone
Shannon Beta Test...

Comments

@Olshansk
Copy link
Member

Objective

Investigate & fix the issue identified during E2E PATH Testing.

Origin Document

See the discord thread here.

Screenshot 2024-12-11 at 5 30 09 PM

Screenshot 2024-12-11 at 5 30 14 PM

Goals & Deliverables

  • Identify the root cause in the issue above
  • Implement a fix
  • Improve the tooling and/or logs to make the issue clearer in the future
  • If applicable, improve the tooling

Deliverables

Creator: @Olshansk
Co-Owners: @okdas @adshmh @red-0ne
@Olshansk Olshansk added the bug Something isn't working label Dec 12, 2024
@Olshansk Olshansk added this to the Shannon Beta TestNet Support milestone Dec 12, 2024
@Olshansk Olshansk added this to Shannon Dec 12, 2024
@Olshansk Olshansk moved this to 🔖 Ready in Shannon Dec 12, 2024
@red-0ne red-0ne mentioned this issue Dec 12, 2024
Merged
14 tasks
red-0ne added a commit that referenced this issue Dec 12, 2024
@red-0ne
fix: Nil session tree logger (#1007)
938f818 
## Summary

This PR initializes the logger of the `SessionTree` by updating the
`ensureSessionTree` function to pass the logger, and modifying test
utilities to support the new logger parameter.

## Issue

- #1006 

## Type of change

Select one or more from the following:

- [ ] New feature, functionality or library
- [ ] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [x] Bug fix
- [ ] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Testing

- [x] **Unit Tests**: `make go_develop_and_test`
- [x] **LocalNet E2E Tests**: `make test_e2e`
- [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

## Sanity Checklist

- [x] I have tested my changes using the available tooling
- [ ] I have commented my code
- [x] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [x] I have left TODOs throughout the codebase, if applicable
@red-0ne
Copy link
Contributor

red-0ne commented Dec 16, 2024

Closing as pr #1007

@red-0ne red-0ne closed this as completed Dec 16, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Shannon Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@red-0ne red-0ne

Labels
bug Something isn't working
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Beta TestNet Support
Development

No branches or pull requests
2 participants
@red-0ne @Olshansk