Skip to content

Commit

Permalink
[fc] Repository: plone.app.z3cform
Browse files Browse the repository at this point in the history
Branch: refs/heads/master
Date: 2018-12-24T11:38:51+01:00
Author: nzambello (nzambello) <[email protected]>
Commit: plone/plone.app.z3cform@c9a9d3f

a11y: added role attr for portalMessage

Files changed:
M CHANGES.rst
M plone/app/z3cform/templates/macros.pt
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-01-05T22:30:19+01:00
Author: Gil Forcada Codinachs (gforcada) <[email protected]>
Commit: plone/plone.app.z3cform@5f647ad

Merge pull request #101 from nzambello/nzambello_a11y_portalMessage

a11y: added role attribute for portalMessage

Files changed:
M CHANGES.rst
M plone/app/z3cform/templates/macros.pt
  • Loading branch information
gforcada committed Jan 5, 2019
1 parent f97bc84 commit 598b78b
Showing 1 changed file with 13 additions and 15 deletions.
28 changes: 13 additions & 15 deletions last_commit.txt
Original file line number Diff line number Diff line change
@@ -1,36 +1,34 @@
Repository: plone.app.multilingual
Repository: plone.app.z3cform


Branch: refs/heads/master
Date: 2018-12-24T12:47:58+01:00
Date: 2018-12-24T11:38:51+01:00
Author: nzambello (nzambello) <[email protected]>
Commit: https://github.com/plone/plone.app.multilingual/commit/79bdffda55a10e7de1c243cf37a09b2c086270b4
Commit: https://github.com/plone/plone.app.z3cform/commit/c9a9d3f5da42a00b6ae5184f65b20a24b992df38

[a11y] Added role attribute for portalMessage + formatted some templates
a11y: added role attr for portalMessage

Files changed:
M CHANGES.rst
M src/plone/app/multilingual/browser/templates/add-form-is-translation.pt
M src/plone/app/multilingual/browser/templates/languages-notice.pt
M plone/app/z3cform/templates/macros.pt

b'diff --git a/CHANGES.rst b/CHANGES.rst\nindex e27f54c7..41f01cad 100644\n--- a/CHANGES.rst\n+++ b/CHANGES.rst\n@@ -14,7 +14,8 @@ New features:\n \n Bug fixes:\n \n-- *add item here*\n+- a11y: Added role attribute for portalMessage\n+ [nzambello]\n \n \n 5.3.1 (2018-12-11)\ndiff --git a/src/plone/app/multilingual/browser/templates/add-form-is-translation.pt b/src/plone/app/multilingual/browser/templates/add-form-is-translation.pt\nindex 5a27ce8a..13a9b3fb 100644\n--- a/src/plone/app/multilingual/browser/templates/add-form-is-translation.pt\n+++ b/src/plone/app/multilingual/browser/templates/add-form-is-translation.pt\n@@ -1,18 +1,18 @@\n <div class="container">\n- <div class="portalMessage info">\n- <strong i18n:translate="" i18n:domain="plone">\n- Info\n- </strong>\n- <tal:block i18n:domain="plone"\n- i18n:translate="add-form-is-translation">\n- This object is going to be a translation to <span i18n:name="language" tal:replace="python:view.language_name(view.language())"></span> from:\n- </tal:block>\n+ <div class="portalMessage info" role="status">\n+ <strong i18n:translate="" i18n:domain="plone">\n+ Info\n+ </strong>\n+ <tal:block i18n:domain="plone"\n+ i18n:translate="add-form-is-translation">\n+ This object is going to be a translation to <span i18n:name="language" tal:replace="python:view.language_name(view.language())"></span> from:\n+ </tal:block>\n <ul>\n- <li tal:repeat="origin view/origin"><span tal:content="python:view.language_name(origin.Language)"></span>: <a href="#" class="link-overlay" tal:attributes="href origin/getURL"> <span tal:content="origin/Title"></span></a></li>\n+ <li tal:repeat="origin view/origin"><span tal:content="python:view.language_name(origin.Language)"></span>: <a href="#" class="link-overlay" tal:attributes="href origin/getURL"> <span tal:content="origin/Title"></span></a></li>\n </ul>\n <span i18n:domain="plone" i18n:translate="create-object-without-translation">\n- If you want to create this object without being a translation press\n- <a href="#" class="link-overlay" i18n:name="url" tal:attributes="href view/returnURL" i18n:translate="">here</a>\n+ If you want to create this object without being a translation press\n+ <a href="#" class="link-overlay" i18n:name="url" tal:attributes="href view/returnURL" i18n:translate="">here</a>\n </span>\n-</div>\n+ </div>\n </div>\ndiff --git a/src/plone/app/multilingual/browser/templates/languages-notice.pt b/src/plone/app/multilingual/browser/templates/languages-notice.pt\nindex c6cda125..5b485d46 100644\n--- a/src/plone/app/multilingual/browser/templates/languages-notice.pt\n+++ b/src/plone/app/multilingual/browser/templates/languages-notice.pt\n@@ -1,4 +1,4 @@\n-<dl class="portalMessage warning">\n+<dl class="portalMessage warning" role="status">\n <dt i18n:translate="" i18n:domain="plone">\n Warning\n </dt>\n'
b'diff --git a/CHANGES.rst b/CHANGES.rst\nindex fdd11f2..7c683d4 100644\n--- a/CHANGES.rst\n+++ b/CHANGES.rst\n@@ -14,7 +14,8 @@ New features:\n \n Bug fixes:\n \n-- *add item here*\n+- a11y: added role attribute for portalMessage\n+ [nzambello]\n \n \n 3.0.8 (2018-11-29)\ndiff --git a/plone/app/z3cform/templates/macros.pt b/plone/app/z3cform/templates/macros.pt\nindex b5d36f1..27a8603 100644\n--- a/plone/app/z3cform/templates/macros.pt\n+++ b/plone/app/z3cform/templates/macros.pt\n@@ -16,13 +16,13 @@\n \n <tal:status define="status view/status;\n has_error python:view.widgets.errors or status == getattr(view, \'formErrorsMessage\', None)" condition="status">\n- <dl class="portalMessage error" tal:condition="has_error">\n+ <dl class="portalMessage error" tal:condition="has_error" role="alert">\n <dt i18n:translate="">\n Error\n </dt>\n <dd tal:content="status" />\n </dl>\n- <dl class="portalMessage info" tal:condition="not:has_error">\n+ <dl class="portalMessage info" tal:condition="not:has_error" role="status">\n <dt i18n:translate="">\n Info\n </dt>\n'

Repository: plone.app.multilingual
Repository: plone.app.z3cform


Branch: refs/heads/master
Date: 2019-01-05T22:26:04+01:00
Date: 2019-01-05T22:30:19+01:00
Author: Gil Forcada Codinachs (gforcada) <[email protected]>
Commit: https://github.com/plone/plone.app.multilingual/commit/fe2abb992ec29fa1f19fbf4a729febc9621a7fd1
Commit: https://github.com/plone/plone.app.z3cform/commit/5f647adc1ddb3e903667ef9652d72c7a0372e047

Merge pull request #332 from nzambello/nzambello_a11y_portalMessage
Merge pull request #101 from nzambello/nzambello_a11y_portalMessage

[a11y] Added role attribute for portalMessage + formatted some templates
a11y: added role attribute for portalMessage

Files changed:
M CHANGES.rst
M src/plone/app/multilingual/browser/templates/add-form-is-translation.pt
M src/plone/app/multilingual/browser/templates/languages-notice.pt
M plone/app/z3cform/templates/macros.pt

b'diff --git a/CHANGES.rst b/CHANGES.rst\nindex e27f54c7..41f01cad 100644\n--- a/CHANGES.rst\n+++ b/CHANGES.rst\n@@ -14,7 +14,8 @@ New features:\n \n Bug fixes:\n \n-- *add item here*\n+- a11y: Added role attribute for portalMessage\n+ [nzambello]\n \n \n 5.3.1 (2018-12-11)\ndiff --git a/src/plone/app/multilingual/browser/templates/add-form-is-translation.pt b/src/plone/app/multilingual/browser/templates/add-form-is-translation.pt\nindex 5a27ce8a..13a9b3fb 100644\n--- a/src/plone/app/multilingual/browser/templates/add-form-is-translation.pt\n+++ b/src/plone/app/multilingual/browser/templates/add-form-is-translation.pt\n@@ -1,18 +1,18 @@\n <div class="container">\n- <div class="portalMessage info">\n- <strong i18n:translate="" i18n:domain="plone">\n- Info\n- </strong>\n- <tal:block i18n:domain="plone"\n- i18n:translate="add-form-is-translation">\n- This object is going to be a translation to <span i18n:name="language" tal:replace="python:view.language_name(view.language())"></span> from:\n- </tal:block>\n+ <div class="portalMessage info" role="status">\n+ <strong i18n:translate="" i18n:domain="plone">\n+ Info\n+ </strong>\n+ <tal:block i18n:domain="plone"\n+ i18n:translate="add-form-is-translation">\n+ This object is going to be a translation to <span i18n:name="language" tal:replace="python:view.language_name(view.language())"></span> from:\n+ </tal:block>\n <ul>\n- <li tal:repeat="origin view/origin"><span tal:content="python:view.language_name(origin.Language)"></span>: <a href="#" class="link-overlay" tal:attributes="href origin/getURL"> <span tal:content="origin/Title"></span></a></li>\n+ <li tal:repeat="origin view/origin"><span tal:content="python:view.language_name(origin.Language)"></span>: <a href="#" class="link-overlay" tal:attributes="href origin/getURL"> <span tal:content="origin/Title"></span></a></li>\n </ul>\n <span i18n:domain="plone" i18n:translate="create-object-without-translation">\n- If you want to create this object without being a translation press\n- <a href="#" class="link-overlay" i18n:name="url" tal:attributes="href view/returnURL" i18n:translate="">here</a>\n+ If you want to create this object without being a translation press\n+ <a href="#" class="link-overlay" i18n:name="url" tal:attributes="href view/returnURL" i18n:translate="">here</a>\n </span>\n-</div>\n+ </div>\n </div>\ndiff --git a/src/plone/app/multilingual/browser/templates/languages-notice.pt b/src/plone/app/multilingual/browser/templates/languages-notice.pt\nindex c6cda125..5b485d46 100644\n--- a/src/plone/app/multilingual/browser/templates/languages-notice.pt\n+++ b/src/plone/app/multilingual/browser/templates/languages-notice.pt\n@@ -1,4 +1,4 @@\n-<dl class="portalMessage warning">\n+<dl class="portalMessage warning" role="status">\n <dt i18n:translate="" i18n:domain="plone">\n Warning\n </dt>\n'
b'diff --git a/CHANGES.rst b/CHANGES.rst\nindex fdd11f2..7c683d4 100644\n--- a/CHANGES.rst\n+++ b/CHANGES.rst\n@@ -14,7 +14,8 @@ New features:\n \n Bug fixes:\n \n-- *add item here*\n+- a11y: added role attribute for portalMessage\n+ [nzambello]\n \n \n 3.0.8 (2018-11-29)\ndiff --git a/plone/app/z3cform/templates/macros.pt b/plone/app/z3cform/templates/macros.pt\nindex b5d36f1..27a8603 100644\n--- a/plone/app/z3cform/templates/macros.pt\n+++ b/plone/app/z3cform/templates/macros.pt\n@@ -16,13 +16,13 @@\n \n <tal:status define="status view/status;\n has_error python:view.widgets.errors or status == getattr(view, \'formErrorsMessage\', None)" condition="status">\n- <dl class="portalMessage error" tal:condition="has_error">\n+ <dl class="portalMessage error" tal:condition="has_error" role="alert">\n <dt i18n:translate="">\n Error\n </dt>\n <dd tal:content="status" />\n </dl>\n- <dl class="portalMessage info" tal:condition="not:has_error">\n+ <dl class="portalMessage info" tal:condition="not:has_error" role="status">\n <dt i18n:translate="">\n Info\n </dt>\n'

0 comments on commit 598b78b

Please sign in to comment.