Skip to content

Commit

Permalink
Merge pull request #101 from nzambello/nzambello_a11y_portalMessage
Browse files Browse the repository at this point in the history 
a11y: added role attribute for portalMessage
  • Loading branch information
@gforcada
gforcada authored Jan 5, 2019
2 parents 56d567a + c9a9d3f commit 5f647ad
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGES.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ New features:

Bug fixes:

- *add item here*
- a11y: added role attribute for portalMessage
[nzambello]


3.0.8 (2018-11-29)
Expand Down
4 changes: 2 additions & 2 deletions plone/app/z3cform/templates/macros.pt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@

<tal:status define="status view/status;
has_error python:view.widgets.errors or status == getattr(view, 'formErrorsMessage', None)" condition="status">
<dl class="portalMessage error" tal:condition="has_error">
<dl class="portalMessage error" tal:condition="has_error" role="alert">
<dt i18n:translate="">
Error
</dt>
<dd tal:content="status" />
</dl>
<dl class="portalMessage info" tal:condition="not:has_error">
<dl class="portalMessage info" tal:condition="not:has_error" role="status">
<dt i18n:translate="">
Info
</dt>
Expand Down

1 comment on commit 5f647ad

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gforcada Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.z3cform/142/violations

plone/app/z3cform/inline_validation.py:15:5: C901 'InlineValidationView.__call__' is too complex (15)
plone/app/z3cform/widget.py:5:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:45:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:70:1: I001 isort found an import in the wrong position
plone/app/z3cform/widget.py:702:19: T000 Todo note found.
plone/app/z3cform/widget.py:716:47: T000 Todo note found.
plone/app/z3cform/converters.py:106:11: T000 Todo note found.
plone/app/z3cform/tests/test_widgets.py:6:1: I001 isort found an import in the wrong position
plone/app/z3cform/tests/test_widgets.py:160:50: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:170:60: C812 missing trailing comma
plone/app/z3cform/tests/test_widgets.py:171:18: C812 missing trailing comma

Follow these instructions to reproduce it locally.

Please sign in to comment.