Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hide document byline viewlet by default #1574

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Conversation

hvelarde
Copy link
Member

@hvelarde hvelarde commented May 5, 2016

It is now controlled by the Allow anyone to view 'about' information option in the Security Settings of Site Setup.

This solves the following issues:

  • document byline would be visible for anonymous users if enabled
  • document byline is not visible for authenticated users as the information it provides should be accessible using the toolbar (there are some pending issues on this, but that must be the final goal)

closes #1556
refs. plone/plone.app.layout#90

@hvelarde
Copy link
Member Author

hvelarde commented May 5, 2016

@plone/framework-team this depends on plone/plone.app.layout#90 and both are ready to review and merging.

@jensens
Copy link
Member

jensens commented May 31, 2016

LGTM - after rebase this and the other pr can be merged.

@hvelarde
Copy link
Member Author

do you realize all the problems we have created by trying to get rid of the document byline? almost all regressions in #957 are caused by that and I have not even mentioned the toolbar cluttering; I want the document byline back so we have time to think about how to fix those issues.

let me know if you need a PLIP.

@jensens
Copy link
Member

jensens commented Jun 2, 2016

i think this is a regression. at least anonymous users should see the byline if setting enabled it. regarding the toolbar there are a bunch of issues, I'd tackle that as a separate problem.

Whats the state of this PRs? I'd like to see this solved for anon.

It is controled by the Allow anyone to view 'about' information option in the Security Settings of Site Setup.
@jensens
Copy link
Member

jensens commented Jun 2, 2016

I rebased and tests are running at the moment.
@hvelarde is anything missing? otherwise i'll merge if tests go green.

@jensens
Copy link
Member

jensens commented Jun 2, 2016

(!) to be merged with plone/plone.app.layout#90

@jensens jensens merged commit 5981f38 into master Jun 2, 2016
@jensens jensens deleted the issue_1556 branch June 2, 2016 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Byline is missing for anonymous user
2 participants