Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byline is missing for anonymous user #1556

Closed
hvelarde opened this issue Apr 29, 2016 · 1 comment · Fixed by #1574
Closed

Byline is missing for anonymous user #1556

hvelarde opened this issue Apr 29, 2016 · 1 comment · Fixed by #1574
Labels
02 type: regression 13 prio: normal 33 needs: docs 99 tag: UX Accessibility Issues that specifically impact a11y

Comments

@hvelarde
Copy link
Member

hvelarde commented Apr 29, 2016 •
edited
Loading

Plone 5.0.4 and again no document byline visible.

according to 1d752d9 the document byline viewlet was hidden without any kind of notice.

enabling it using the @@manage-viewlets makes it visible to authenticated users but not to anonymous users.

Refs. #668 and #741
@hvelarde
Copy link
Member Author

hvelarde commented May 5, 2016

I forgot to enable the display of this viewlet on Site Setup -> Security Settings:

selection_068

in fact this could solve part of the issue if we display the viewlet just for anonymous users.

hvelarde added a commit to plone/plone.app.layout that referenced this issue May 5, 2016
@hvelarde
Document byline viewlet is now displayed only to anonymous users
1845be1 
If permited by the Allow anyone to view 'about' information option in the Security Settings of Site Setup.

Refs: plone/Products.CMFPlone#1556
@hvelarde hvelarde mentioned this issue May 5, 2016
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Jun 2, 2016
@jensens
[fc] Repository: plone.app.layout
5c25899 
Branch: refs/heads/master
Date: 2016-05-05T11:48:48-03:00
Author: hvelarde (hvelarde) <[email protected]>
Commit: plone/plone.app.layout@1845be1

Document byline viewlet is now displayed only to anonymous users

If permited by the Allow anyone to view 'about' information option in the Security Settings of Site Setup.

Refs: plone/Products.CMFPlone#1556

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/content.py
Repository: plone.app.layout
Branch: refs/heads/master
Date: 2016-05-05T18:48:15-03:00
Author: hvelarde (hvelarde) <[email protected]>
Commit: plone/plone.app.layout@7a603af

Remove code used to show the lock status and history view in the document byline, as this information was not available to anonymous users anyway

We need to review if this is available in the current implementation of the toolbar.

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/content.py
M plone/app/layout/viewlets/document_byline.pt
M plone/app/layout/viewlets/tests/test_content.py
Repository: plone.app.layout
Branch: refs/heads/master
Date: 2016-06-03T01:06:06+02:00
Author: Jens W. Klein (jensens) <[email protected]>
Commit: plone/plone.app.layout@5e486e8

Merge pull request #90 from plone/issue_1556

Display document byline viewlet only to anonymous users

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/content.py
M plone/app/layout/viewlets/document_byline.pt
M plone/app/layout/viewlets/tests/test_content.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02 type: regression 13 prio: normal 33 needs: docs 99 tag: UX Accessibility Issues that specifically impact a11y
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not hide document byline viewlet by default plone/Products.CMFPlone
1 participant
@hvelarde