fix(docs): fixed css code for custom patternstates color #1219
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recognized this out of fix reported by pattern-lab#1216
JosefBredereck
approved these changes
Jun 12, 2020
I'm about to merge this down so I can get a release cut shortly but just wanted to double check @mfranzke if your question was answered ^ |
|
@sghoweri, I‘ll make this a question in glitter and/or probably an issue afterwards. Than we could easily close this ticket here. |
|
PR was released with v5.11.1 |
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
…te-custom-color fix(docs): fixed css code for custom patternstates color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
didn't open another issue for this quick docs fix.
Summary of changes:
Corrected the specs regarding new / custom states color, aligned with the newer syntax in file https://github.com/pattern-lab/patternlab-node/blob/dev/packages/uikit-workshop/src/sass/scss/04-components/_pattern-states.scss
Recognized this out of fix made that was the issue reported by #1216
btw. what about the specs in the folder
/packages/docs/php-docs/pattern-states.md, do you (still) change all of those accordingly ?