Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No css for pattern state "inprogress" #1216

Closed
perriard opened this issue Jun 11, 2020 · 2 comments · Fixed by #1218
Closed

No css for pattern state "inprogress" #1216

perriard opened this issue Jun 11, 2020 · 2 comments · Fixed by #1218

Comments

@perriard
Copy link

I am using Pattern Lab Node v5.7.0 on Mac, with Node v11.3.0, using a Custom Edition.

Expected Behavior

Pattern state "inprogress" produces a red dot

Actual Behavior

Pattern state "inprogress" produces a blue dot (defaults to the .pl-c-pattern-state styling - there is no --inprogress variant in the uikit _pattern-states.scss)

Steps to Reproduce
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Jun 11, 2020
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Jun 11, 2020
@mfranzke
Copy link
Contributor

@perriard thanks a lot for that finding. I've even already provided a fix and recognized another inconsistency within the spec.

sghoweri added a commit that referenced this issue Jun 28, 2020
…ress

fix(patternstate): added css color for pattern state "inprogress" #1216
@sghoweri
Copy link
Contributor

Issue was released with v5.11.1

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
…tate-inprogress

fix(patternstate): added css color for pattern state "inprogress" pattern-lab#1216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants