Fix plugin tabs enabling multiple file formats #1165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get upstream
get upstream
…to-configure-default-pattern-info-code-panel
added some more details
missed to replace mustache initially and incorrect handlebars two times (both in package name and URL)
This reverts commit 271dc8d.
This reverts commit d5d6bf4.
…ern-info-code-panel
…ern-info-code-panel
…ode-panel' into fix-plugin-tabs-enabling-multiple-file-formats
|
there seems to have been some problems with the code ... will open another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1163
Blocked by #1155 #1156 (#1156 has been already merged into this branch, as it's related)
Summary of changes:
Reverted parts to the previously used placeholders within the
/packages/plugin-tab/src/snippet.jsfile, and modified/packages/plugin-tab/dist/js/@pattern-lab-plugin-tab.jsaccordingly by migrating some code to that file.This would reenable defining one or more filetypes to display within the code panels again.