Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: ability to configure default pattern info code panel #1155

Closed
mfranzke opened this issue Apr 24, 2020 · 4 comments · Fixed by #1156
Closed

improvement: ability to configure default pattern info code panel #1155

mfranzke opened this issue Apr 24, 2020 · 4 comments · Fixed by #1156

Comments

@mfranzke
Copy link
Contributor

Being able to configure the initial pattern info code panel instead of always using the pattern template being used by the design system e.g. offers showing the HTML code initially.

That HTML code might be the most relevant code for diverse systems or target template usage in larger constructs or enterprises, where a central design system team e.g. uses handlebars, but the HTML gets integrated into several different template languages afterwards.
mfranzke added a commit to mfranzke/patternlab-node that referenced this issue Apr 24, 2020
@mfranzke
improvement: ability to configure default pattern info code panel pat…
d3c47ab 
…tern-lab#1155
@mfranzke mfranzke mentioned this issue Apr 24, 2020
Merged
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Apr 25, 2020
chore(config): added new default config value pattern-lab#1155
53d2dd6
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Apr 25, 2020
chore(config): added new default config value pattern-lab#1155
d5d6bf4
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Apr 25, 2020
docs(config): added the default config values pattern-lab#1155
ea4c2c2
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Apr 25, 2020
docs(config): added the default config values pattern-lab#1155
50771b4 
added some more details
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Apr 25, 2020
Revert "chore(config): added new default config value pattern-lab#1155"
753b91a 
This reverts commit d5d6bf4.
This was referenced Apr 28, 2020
Closed
Merged
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Apr 29, 2020
improvement(plugintabs): added part of pattern-lab#1155 pattern-lab#1156
2b60488 


even already to this checkin
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue May 1, 2020
Revert "chore(config): added new default config value pattern-lab#1155"
ecab814 
This reverts commit 53d2dd6.
@stale
Copy link

stale bot commented Jun 23, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@mfranzke
Copy link
Contributor Author

Actually the merge request for this ticket just needs to get reviewed ... and merged.

@stale
Copy link

stale bot commented Aug 22, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

JosefBredereck added a commit that referenced this issue Aug 25, 2020
@mfranzke @bmuenzenmeyer @JosefBredereck
improvement: ability to configure default pattern info code panel #1155…
c3fa917 
… (#1156)

* improvement: ability to configure default pattern info code panel #1155
* docs(config): added the default config values #1155

Co-authored-by: Maximilian Franzke <[email protected]>
Co-authored-by: Maximilian Franzke <[email protected]>
Co-authored-by: Maximilian Franzke <[email protected]>
Co-authored-by: Brian Muenzenmeyer <[email protected]>
Co-authored-by: Josef Bredreck <[email protected]>
@JosefBredereck
Copy link
Contributor

The issue was released with v5.13.0 🎉

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
improvement(plugintabs): added part of pattern-lab#1155 pattern-lab#1156
3259f45 


even already to this checkin
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
@mfranzke @bmuenzenmeyer @JosefBredereck
improvement: ability to configure default pattern info code panel pat…
7559cbd 
…tern-lab#1155 (pattern-lab#1156)

* improvement: ability to configure default pattern info code panel pattern-lab#1155
* docs(config): added the default config values pattern-lab#1155

Co-authored-by: Maximilian Franzke <[email protected]>
Co-authored-by: Maximilian Franzke <[email protected]>
Co-authored-by: Maximilian Franzke <[email protected]>
Co-authored-by: Brian Muenzenmeyer <[email protected]>
Co-authored-by: Josef Bredreck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement: ability to configure default pattern info code panel #1155 mfranzke/patternlab-node
2 participants
@mfranzke @JosefBredereck