-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use newer jwks-rsa library and its async/await functions #7305
Use newer jwks-rsa library and its async/await functions #7305
Conversation
af8d93c
to
04ecba8
Compare
Codecov Report
@@ Coverage Diff @@
## master #7305 +/- ##
==========================================
- Coverage 93.93% 93.91% -0.02%
==========================================
Files 181 179 -2
Lines 13194 13168 -26
==========================================
- Hits 12394 12367 -27
- Misses 800 801 +1
Continue to review full report at Codecov.
|
To clarify for reviewers, this PR intents to upgrade a dependency and switch from promisify to async/await. Bumping the min Node.js requirement is merely a side effect, but it makes also sense for another reason because Parse Server is officially only compatible (and tested) with Node >= 10. @olleolleolle Could you please change the PR issue and approach to be specific to the referring issue to prevent any confusion? |
04ecba8
to
871e4c5
Compare
871e4c5
to
a6cba61
Compare
Ah, perfect, the right tests are failing, I'll get to that. (I can see how I missed them locally: they are |
This pushes up to declare Node 10+ as a requirement, but we were using that in practice, before, too. jwks-rsa CHANGELOG mentions this upgrade guide: https://github.com/auth0/node-jwks-rsa/blob/master/CHANGELOG.md#migrated-callbacks-to-asyncawait
b52b65b
to
85fb56b
Compare
@mtrezza 👋 Hi, I know that I won't have time to get the tests in shape in the forseeable future, so please do investigate. Acceptable alternative: close this PR. |
Thanks for the update, let's leave this open for now, if someone wants to pick this up. |
|
Closing via #7304 (comment) |
New Pull Request Checklist
Issue Description
This adds the requirement "parse-server works with Node 10 and newer" a real thing in
package.json
.This PR intends to upgrade a dependency and switch from promisify to async/await.
Bumping the min Node.js requirement is merely a side-effect, but it makes also sense for another reason because Parse Server is officially only compatible (and tested) with Node >= 10.
Related issue: #7304
Approach
(I attempted to run
npm install
, but that happened to have a newer npm (7) which bumped the lockfileVersion. Hm. Not what I wanted to do.)TODOs before merging
Current trouble w/ my bad use of the tests: