You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
👋 Hello, I hope this "this is a hunch for avoiding some complexity" Issue sits in the right place.
The dependency jwks-rsa has a new interface: its client methods are now no longer callbacks but directly awaitable things. We no longer need to use promisify() around them.
Using this new 2.x version would simplify our code.
New Issue Checklist
Issue Description
👋 Hello, I hope this "this is a hunch for avoiding some complexity" Issue sits in the right place.
The dependency jwks-rsa has a new interface: its client methods are now no longer callbacks but directly
await
able things. We no longer need to usepromisify()
around them.Using this new 2.x version would simplify our code.
Upgrade guide (this is the one thing in the guide which impacts us):
https://github.com/auth0/node-jwks-rsa/blob/master/CHANGELOG.md#migrated-callbacks-to-asyncawait
New Requirement: Node 10+.
I can see in package.json that 8+ is in our "engines". Can that be bumped?
Locations in our code where used: facebook, apple auth adapters.
parse-server/src/Adapters/Auth/facebook.js
Line 55 in 92f50f6
parse-server/src/Adapters/Auth/apple.js
Line 12 in 033a0bd
Steps to reproduce
Well, one can try installing parse-server with yarn and there are notes about
Actual Outcome
Um, existing code.
Expected Outcome
It would be simpler code to use the new API. Also, they dropped the Axios dep.
Failing Test Case / Pull Request
Sorry, no test case.
Environment
Server
4.5.0
Linux
local
Database
mongo
idk
local
Client
javascript
idk
Logs
(No logs.)
The text was updated successfully, but these errors were encountered: