Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename statemint/statemine/westmint to asset-hub-polkadot/kusama/westend #1296

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

Imod7
Copy link
Contributor

@Imod7 Imod7 commented Jun 19, 2023

Changes

Following the changes made in the Cumulus PR Rename Statemint to Asset Hub #2633, the following renamings were made in Sidecar :

  • statemint -> asset-hub-polkadot or assetHubPolkadot depending on the instance
  • statemine -> asset-hub-kusama or assetHubKusama depending on the instance
  • westmint -> asset-hub-westend

Exceptions

No renamings were made in :

  1. the URL endpoint wsUrl: 'wss://statemine-rpc.polkadot.io' of the config.ts file
  2. the URL endpoint wsUrl: 'wss://statemint-rpc.polkadot.io' of the config.ts file
  3. the specName mentioned in 340000.json file
  4. the specName mentioned in 993450.json file

The above was also not changed in the PR.

Important Note

Failed to rename this line

rococoRegistry.createType('Bytes', 'statemint'),

because I get the following error when yarn test

c/services/pallets/PalletsAssetsService.spec.ts
  ● PalletsAssetsService › PalletsAssetsService.fetchAssetById › Should return the correct response for an AssetId

    expect(received).toStrictEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 1

    @@ -15,11 +15,11 @@
        },
        "assetMetaData": Object {
          "decimals": "10",
          "deposit": "2000000",
          "isFrozen": false,
    -     "name": "0x73746174656d696e74",
    +     "name": "0x6173736574487562506f6c6b61646f74",

@Imod7 Imod7 requested a review from a team as a code owner June 19, 2023 18:07
@Imod7 Imod7 merged commit 362e912 into master Jun 20, 2023
@Imod7 Imod7 deleted the domi-asset-hub-renaming branch June 20, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants