Rename Statemint to Asset Hub #2633
Conversation
joepetrowski
added
A3-in_progress
|
Rebased |
| /// Westend chain id. | ||
| pub const WESTMINT_CHAIN_ID: ChainId = *b"wmnt"; | ||
| /// AssetHubWestend chain id. | ||
| pub const ASSET_HUB_WESTEND_CHAIN_ID: ChainId = *b"ahwe"; |
There was a problem hiding this comment.
I presume this is not used anywhere live, and has no consequence to change?
There was a problem hiding this comment.
Correct, #2633 (comment)
| @@ -94,6 +94,9 @@ impl_opaque_keys! { | |||
| #[cfg(feature = "state-trie-version-1")] | |||
| #[sp_version::runtime_version] | |||
| pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| // Note: "statemine" is the legacy name for this chain. It has been renamed to | |||
There was a problem hiding this comment.
I wish there was a way to have a more concrete and delicate plan here, similar to https://github.com/paritytech/substrate/issues/13976#issuecomment-1568538473
There was a problem hiding this comment.
Yeah, I was thinking the same. There's not really a good way to change it except to leave it, hope enough tools update to support the change, and then break it.
| @@ -74,7 +74,7 @@ pub mod fee { | |||
| type Balance = Balance; | |||
There was a problem hiding this comment.
FYI this stuff can easily be rfactored out to runtime_common with something like RefTimeToFee<const COEFFICIENT> or similar.
|
bot merge |
* Rename Statemint and Statemine ref # paritytech/cumulus#2633 * Fix chainspecs * Rename westmint and rockmine
Logged an issue with DevOps, but
statemintobviously stays unchanged in WSS/bootnode paths until renaming/redirects are in place.Does not change the on-chain
spec_name, as many wallets rely on this name.Closes #2591
CC Docs/DevEx @sacha-l and Wiki @DrW3RK and Apps @jacogr