Process GrandPa commit messages #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finished the commits verification code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #366
Implements processing the incoming GrandPa commit messages to update finality.
Doesn't actually work because full nodes don't send commit messages to light clients. In order to test, one must replace
LightwithFullin the network service. André is working on changing this in Substrate.Apart from this, the code actually works well. Most notably, there's no panic in the syncing or anywhere else.
This PR is still work in progress because the commit messages aren't actually verified and just assumed to be correct. The problem I'm facing is that the actual verification code is very close to the code that verifies a justification, but I don't want to copy-paste it and I'm having trouble finding some common abstraction/ground.