Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle GrandPa commit messages that aren't verifiable yet #851

Closed
tomaka opened this issue May 21, 2021 · 1 comment
Closed

Properly handle GrandPa commit messages that aren't verifiable yet #851

tomaka opened this issue May 21, 2021 · 1 comment

Comments

@tomaka
Copy link
Contributor

tomaka commented May 21, 2021

#846 implements processing GrandPa commit messages.
However, if a GrandPa commit can't be verified because not all blocks are known, we simply discard the commit.
It should instead result in downloading the unknown blocks and trying to verify the commit again.

In order to not have an unbounded queue of not-yet-verifiable commits, we should limit ourselves to two pending commits per peer: for each peer, the not-verifiable-yet commit with the lowest target and the not-verifiable-yet commit with the highest target.

Thanks to this, it will be possible for finality to ultimately progress whatever the situation, provided that at least one peer isn't malicious.

@tomaka
Copy link
Contributor Author

tomaka commented Jun 20, 2022

This was done in #2400

@tomaka tomaka closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant