Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More backports to the JSON-RPC API #2818

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Oct 4, 2022

In complement with #2812, this PR updates chainHead_unstable_storage with the latest changes in the JSON-RPC API: paritytech/json-rpc-interface-spec#16 and paritytech/json-rpc-interface-spec#17

We should now be up to date.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
      -45357 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::hf0bb040c12dd59ea
      +45116 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::hdf8d18d77f4eb404
      -10991 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h7922c1a3ab04022e
      +10964 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h0344c5703f5acef6
       -4232 ┊ <smoldot::json_rpc::methods::MethodCall as core::fmt::Debug>::fmt::ha9f621c06b20646d
       +4194 ┊ <smoldot::json_rpc::methods::MethodCall as core::fmt::Debug>::fmt::had77ac6f55685ee5
       -2720 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hab3687bae086912c
       +2634 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h625f3d727ee0b41b
       -1963 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hd1921350ebc70ecc
       +1871 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h23d48ccebfa20834
       -1511 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>::handle_request::{{closure}}>>::h89e27af67381e134
       +1511 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>::handle_request::{{closure}}>>::hf39254af46e65c60
        +619 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::ChainHeadStorageEvent>::serialize::h9dcea034067e6547
        -616 ┊ <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_key_seed::h4c7b6d8bbc0b9423
        +616 ┊ <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_key_seed::hb2e2bf590c276b63
        -588 ┊ core::ptr::drop_in_place<smoldot::json_rpc::methods::MethodCall>::h9a8fa1eb7c2d821a
        +588 ┊ core::ptr::drop_in_place<smoldot::json_rpc::methods::MethodCall>::hff3e40f09afb59cd
        -516 ┊ smoldot::json_rpc::methods::_::<impl serde::de::Deserialize for smoldot::json_rpc::methods::StorageQueryType>::deserialize::h810c5f8f18ed591f
        -491 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::ChainHeadStorageEvent>::serialize::hbc596267f1c8508b
        -478 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::TransactionStatus>::serialize::h0c56dc89f6c67fc4
       -2147 ┊ ... and 58 more.
       -6153 ┊ Σ [78 Total Rows]

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Oct 4, 2022
@mergify mergify bot merged commit c0b8cfa into paritytech:main Oct 4, 2022
@tomaka tomaka deleted the more-fixes-json-rpc branch October 4, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants